Following on from the discussion at https://www.drupal.org/node/1627806#comment-9299837:

On both the node form and the menu settings page, I have found that the 'Menu item attributes' fieldset is now collapsed by default, but the 'Menu link attributes' are still expanded by default.

It would be helpful to me (and my clients!) if this could also be collapsed by default.

Thanks again

CommentFileSizeAuthor
#8 make_menu_link-2368087-8.patch435 bytesredndahead
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ressa’s picture

ressa CreditAttribution: ressa commented
Category: Feature request » Bug report

I agree, it should be collapsed. You can fix it temporarily until it is fixed in the module by setting #collapsed to TRUE in the menu_attributes.module file like this:

  $form['options'][MENU_ATTRIBUTES_LINK] = array(
    '#type' => 'fieldset',
    '#title' => t('Menu link attributes'),
    '#collapsible' => TRUE,
    '#collapsed' => TRUE,
    '#tree' => TRUE,
  );
limehouse’s picture

limehouse CreditAttribution: limehouse commented
Issue summary: View changes
limehouse’s picture

limehouse CreditAttribution: limehouse commented

Thanks that's very helpful.

commonpike’s picture

commonpike CreditAttribution: commonpike commented

+1, came here only to look for this .. issue.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Status: Active » Fixed

Thanks, fixed in dev.

  • joelpittet committed e479fea on 7.x-1.x 
    Issue #2368087: Make 'Menu link attributes' collapsed by default

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

redndahead’s picture

redndahead CreditAttribution: redndahead commented
FileSize
make_menu_link-2368087-8.patch435 bytes

This is the committed patch for 1.0-rc3 so people can use it in their make files.

joelpittet’s picture

joelpittet
Primary language English
Location Vancouver
CreditAttribution: joelpittet commented
Version: 7.x-1.0-rc3 » 7.x-1.x-dev

Oh thanks, I should have posted that.

adriaanm’s picture

adriaanm CreditAttribution: adriaanm commented

Any idea when this could get released in a next RC?

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
CreditAttribution: scotwith1t at Inner File Software commented

Bump. New release with this in it would be super-awesome. Thx! :)

scotwith1t’s picture

scotwith1t
Location Birmingham, AL
CreditAttribution: scotwith1t at Inner File Software commented

There is a patch at #2390755: Different permissions suggestion and empty fieldsets which is RTBC for a lingering bug (hide empty fieldset if no options are enabled). Once committed, a new release should be forthcoming with this fixed as well.