It has been my policy to make a patch for every 7.x-4.x commit, apply it to 8.x, upload it, and set the issue to 8.x. As more of the webform codebase is ported to 8.x, this creates the possibility that I might apply a patch to something that has already been ported. For example, I recently added a couple of variable_get() type variables, which would be CMI config in 8.x.

How would the 8.x contributors and maintainer like 7.x-4.x patches handled as a workflow? Is it sufficient for them to just be sure to review updated issues that are 8.x and fixed?

Comments

fenstrat’s picture

fenstrat
he/him
Primary language English
Location Australia
CreditAttribution: fenstrat commented
Status: Active » Fixed

Thanks for bringing this up Dan. Yeah I'd say that if the 7.x patch applies to 8.x then go ahead and commit it. Generally if it applies it means the 8.x version hasn't been touched. I am checking all D8 commits I don't make to make sure there's no regressions, this will obviously require more and more work as the D8 version goes forward, but I can't really think of a better way to manage it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.