[D7] HTML5 Colorpicker [#2366647]

The HTML5 Colorpicker creates a new Form API element type: html5_colorpicker. After enabling this module a new form element can be created and included in any form in this way:

$form['element'] = array(
  '#type' => 'html5_colorpicker',
  '#title' => t('Color'),
  '#default_value' => 'FFFFFF',
);

This will automatically place the colorpicker into the form, allowing users of the form to choose a color.

This module includes Field API integration. The picker can be added as a field to any content type.

The HTML5 Colorpicker is an adaptation of the Drupal 7 Jaypan's Jquery Colorpicker, with the Script Tutorials' HTML5 Color Picker (canvas) code.

It doesn't require a 3rd party library, and uses the HTML5 canvas tab. This module is intended only for Drupal 7.x.

Link to your project page: https://www.drupal.org/sandbox/ssanchez77/2366563

Git clone command: git clone --branch master http://git.drupal.org/sandbox/ssanchez77/2366563.git html5_colorpicker

Comments

Comment #1

PA robot CreditAttribution: PA robot commented 31 October 2014 at 05:24

Status:

Needs review

» Needs work

Git clone failed for http://git.drupal.org/sandbox/ssanchez77/2366563.git while invoking http://pareview.sh/pareview/httpgitdrupalorgsandboxssanchez772366563git

Git clone failed. Aborting.

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

Comment #2

ssanchez77 CreditAttribution: ssanchez77 commented 13 November 2014 at 21:46

Issue summary:

View changes

Comment #3

ssanchez77 CreditAttribution: ssanchez77 commented 13 November 2014 at 21:49

Issue summary:

View changes

Comment #4

ssanchez77 CreditAttribution: ssanchez77 commented 13 November 2014 at 22:49

Status:

Needs work

» Needs review

I checked the git clone command and it's working OK.

git clone --branch master http://git.drupal.org/sandbox/ssanchez77/2366563.git html5_colorpicker

Comment #5

Fabulous CreditAttribution: Fabulous commented 14 November 2014 at 14:43

Status:

Needs review

» Needs work

Automated Review

First of all you have lots of errors on the automated review, please fix it first: http://pareview.sh/pareview/httpgitdrupalorgsandboxssanchez772366563git

Manual Review

Individual user account: Yes: Follows the guidelines for individual user accounts.
No duplication: No: there are already modules which does this feature: https://www.drupal.org/project/jquery_colorpicker, https://www.drupal.org/project/color_field . duplication and/or fragmentation.
Master Branch: Yes: Follows the guidelines for master branch.
Licensing: Yes: Follows the licensing requirements.
3rd party assets/code: No: Does not follow the guidelines for 3rd party assets/code. You put a library with MIT license in it, only GPL, GPL v2+ are allowed.
README.txt/README.md: No: Does not follow the guidelines for in-project documentation and/or the README Template. Please use the syntax of the template.
Code long/complex enough for review: Yes: Follows the guidelines for project length and complexity.
Secure code: Yes: Meets the security requirements.
Coding style & Drupal API usage: Start by fixing automated review first please, before I look in details your code.

This review uses the Project Application Review Template.

Comment #6

ssanchez77 CreditAttribution: ssanchez77 commented 14 November 2014 at 19:33

Thank you. I'll check the automated review errors. I'm making my fists steps in this so I'm a little confuse with the process.

Regarding the 3rd party assets/code, I based my library on the HTML5 Color Picker (canvas) sample, but the Drupal.behaviors.html5Colorpicker code is really my own. My mistake was to let the headers as I put them in the beginning. I'll remove the copyright references.

About the duplication, even when the feature is the same (a color picker), my module uses a completely diferente control to achieve the task, and an HTML5 feature (canvas) for it. Please let me know if we can talk more about this. I already contact the Jquey Colorpicker module maintainers and they are interested in the result of this new approach.

I'll check the other points. Thanks again.

Comment #7

Fabulous CreditAttribution: Fabulous commented 17 November 2014 at 08:20

Why do you not just ask them to include your work in their module ? Maybe you can become a maintainer of the project.
I know that I prefer to have an option of configuration which allows me to choose between JS and HTML 5 than two modules ...

Comment #8

ssanchez77 CreditAttribution: ssanchez77 commented 20 November 2014 at 15:39

Yeah... I'll contact them. Thanks for your help. I'll let you know what happened.

Comment #9

PA robot CreditAttribution: PA robot commented 2 February 2015 at 17:24

Status:

Needs work

» Closed (won't fix)

Closing due to lack of activity. If you are still working on this application, you should fix all known problems and then set the status to "Needs review". (See also the project application workflow).

I'm a robot and this is an automated message from Project Applications Scraper.