Doesn't save if other entity fields have errors [#2364867]

I have a view with two number fields that I have editable. The client reported that some rows were updating but others were not. It would look like it saved, but if you refreshed, you'd see it didn't take. It turns out if you edit the node the normal way, then you could edit it with editable fields. If the node had just been created and never edited, then editable fields didn't save changes. Any thoughts as to what editing a node the traditional way does to change it?

As a workaround in the meantime, I just went in and re-saved all of their nodes and then editable fields works fine.

Comment	File	Size	Author
#6	editablefields-omit_other_errors-2364867-6.patch	598 bytes	skylord

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

mattplu CreditAttribution: mattplu commented 17 March 2015 at 02:20

Were you ever able to find a solution to this?

Having the same problem now.

Comment #2

troybthompson CreditAttribution: troybthompson commented 18 March 2015 at 17:45

Unfortunately no, but once you edit them once normally, it works from then on out.

Comment #3

IckZ CreditAttribution: IckZ commented 30 July 2015 at 13:03

Today I recognized the same problem. My commerce products aren't saved via editable fields until I go into the product and re-save it. After this everything works fine.

Befor resaving I get two errors in the logs:

Notice: Undefined index: commerce_stock in editablefields_form_submit() (line 565 in /../sites/all/modules/editablefields/editablefields.module).

and

Warning: Invalid argument supplied for foreach() in editablefields_form_submit() (line 565 in /../sites/all/modules/editablefields/editablefields.module).

after re-saving and setting a field value with editablefields no errors appear and the value is saved successfully.

The Problem is also not only for the stock_field. The error from above appears for every single field which is editable bevore I do a manually re-save.

All products which show these behavoir where created by feeds importer. Is there maybe a value missing which is important for editiable fields if nodes or products are created by feeds?
Any ideas what the problem should be?

Comment #4

IckZ CreditAttribution: IckZ commented 30 July 2015 at 12:57

Priority:

Normal

» Major

Comment #5

IckZ CreditAttribution: IckZ commented 30 July 2015 at 14:01

Priority:

Major

» Minor

got it :).
After setting a dsm($error) in line 565 I could see, that an other field of the product was marked with

"list_illegal_value"

After this, I was able to find the error. In my case it was an whitespace in the uploaded .csv file after the field value of an other field. That was why the data of the field was not saved and editablefields wasn't able to save the whole product by editing the other fields.

Comment #6

skylord CreditAttribution: skylord commented 10 September 2015 at 13:12

Title:	Doesn't save until edited through full edit form first	» Doesn't save if other entity fields have errors
Status:	Active	» Needs review

File	Size
editablefields-omit_other_errors-2364867-6.patch	598 bytes

The same for me - there were a bunch of Feeds imported as Profile2 entities and some of them contained errors not caused by fields edited as editablefields. Think that editablefields should not validate other fields and deal only with own ones. So, here is simple pathc for it - works OK for me.