Gigya 7.x-4.6 doesn't follow the drupal coding standard

Coder Module returns

SITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA.MODULE
gigya.module

severity: normalreview: style_else_spacingLine 67: else statements should begin on a new line [style_else_spacing]
    } else {
severity: normalreview: i18n_0Line 171: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        array('!website' => l('website', 'http://www.gigya.com/products/',
severity: normalreview: style_uppercase_constantsLine 603: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE [style_uppercase_constants]
  return drupal_json_decode(variable_get('gigya_gm_' . $plugin_name . '_advanced', null));
severity: normalreview: style_else_spacingLine 864: else statements should begin on a new line [style_else_spacing]
  } elseif ($form_id == 'user_login') {
severity: normalreview: style_else_spacingLine 884: else statements should begin on a new line [style_else_spacing]
  }elseif ($form_id == 'user_login_block') {
severity: normalreview: style_else_spacingLine 909: else statements should begin on a new line [style_else_spacing]
  } elseif ($form_id == 'gigya_admin_form') {
severity: normalreview: style_else_spacingLine 913: else statements should begin on a new line [style_else_spacing]
  } elseif ($form_id == 'user_pass') {
severity: normalreview: style_else_spacingLine 1395: else statements should begin on a new line [style_else_spacing]
    } else {
severity: normalreview: style_else_spacingLine 1435: else statements should begin on a new line [style_else_spacing]
    } else {
severity: normalreview: style_else_spacingLine 1581: else statements should begin on a new line [style_else_spacing]
      } else {
severity: normalreview: style_comma_spacingLine 1584: missing space after comma [style_comma_spacing]
      form_set_error($element['name'],$err);
severity: normalreview: style_else_spacingLine 1586: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_else_spacingLine 1695: else statements should begin on a new line [style_else_spacing]
  } else {
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/GSSDK.PHP
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/GIGYAUSER.INC
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA.ADMIN.INC
gigya.admin.inc

severity: normalreview: i18n_0Line 32: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!Dashboard' => l('Dashboard', 'https://console.gigya.com/Site/partners/Dashboard.aspx', array(
severity: normalreview: i18n_0Line 111: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!add_connections' => l('Learn more in Add Connections without Logging in.', 'http://developers.gigya.com/010_Developer_Guide/10_UM360/070_Connect#Add_Connections_without_Logging_in',
severity: normalreview: i18n_0Line 141: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 374: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
          l('Login Plugin', 'http://developers.gigya.com/020_Client_API/010_Socialize/Socialize.showLoginUI',
severity: normalreview: i18n_0Line 395: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 515: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: style_control_spacingLine 568: Control statements should have one space between the control keyword and opening parenthesis [style_control_spacing]
    if(module_exists("profile2")) {
severity: normalreview: style_control_spacingLine 582: Control statements should have one space between the control keyword and opening parenthesis [style_control_spacing]
    } elseif(isset($info['columns']['value']['size'])) {
severity: normalreview: style_else_spacingLine 582: else statements should begin on a new line [style_else_spacing]
    } elseif(isset($info['columns']['value']['size'])) {
severity: normalreview: style_control_spacingLine 646: Control statements should have one space between the control keyword and opening parenthesis [style_control_spacing]
  if(!empty($mappings)) {
severity: normalreview: style_else_spacingLine 729: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: i18n_0Line 891: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 937: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!setup' => l('Comments Setup', 'https://console.gigya.com/Site/partners/Settings.aspx#cmd%3DSettings.CommentsSetup',
severity: normalreview: i18n_0Line 988: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 1137: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 1385: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 1405: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 1425: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 1445: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 1465: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
        '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: style_else_spacingLine 1514: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_array_spacingLine 1760: Arrays should be formatted with a space separating each element and assignment operator [style_array_spacing]
    '#attributes' =>array('placeholder' => $follow_bar_placeholder),
severity: normalreview: i18n_0Line 1779: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
          '!JSON' => l('JSON', 'http://json.org', array('external' => TRUE, 'attributes' => array('target' => '_blank'))
severity: criticalreview: security_4Line 1790: Potential problem: form_set_error() and form_error() only accept filtered text, be sure to use check_plain(), filter_xss() or similar to ensure your $variable is fully sanitized. (Drupal Docs) [security_4]
    form_set_error($element['#name'], $element['#title'] . ": " . join(', ', $valid));
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA.API.PHP
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA.INC
gigya.inc

severity: normalreview: style_function_spacingLine 340: Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
  ini_restore ( 'arg_separator.output' );
severity: normalreview: style_function_spacingLine 596: Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
  ini_restore ( 'arg_separator.output' );
severity: normalreview: style_uppercase_constantsLine 622: Use uppercase for PHP constants, e.g. NULL, TRUE, FALSE [style_uppercase_constants]
    'isActive' => false
severity: normalreview: style_else_spacingLine 734: else statements should begin on a new line [style_else_spacing]
    } else {
severity: normalreview: style_else_spacingLine 738: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_control_spacingLine 748: Control statements should have one space between the control keyword and opening parenthesis [style_control_spacing]
    } elseif(gettype($array) == 'array') {
severity: normalreview: style_else_spacingLine 748: else statements should begin on a new line [style_else_spacing]
    } elseif(gettype($array) == 'array') {
severity: normalreview: style_else_spacingLine 750: else statements should begin on a new line [style_else_spacing]
    } else {
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA.INSTALL
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA.PAGES.INC
gigya.pages.inc

severity: normalreview: style_else_spacingLine 149: else statements should begin on a new line [style_else_spacing]
    } else {
severity: normalreview: style_function_spacingLine 175: Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
          user_cookie_save(array ('gigya' => 'gigyaLogOut'));
severity: normalreview: style_else_spacingLine 205: else statements should begin on a new line [style_else_spacing]
              } else {
severity: normalreview: style_else_spacingLine 231: else statements should begin on a new line [style_else_spacing]
                  } else {
severity: normalreview: style_function_spacingLine 244: Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
              user_cookie_save(array ('gigya' => 'gigyaLogOut'));
severity: normalreview: style_control_spacingLine 276: Control statements should have one space between the control keyword and opening parenthesis [style_control_spacing]
            if(gigya_check_username_available($uname)) {
severity: normalreview: style_else_spacingLine 278: else statements should begin on a new line [style_else_spacing]
            } else {
severity: normalreview: style_else_spacingLine 282: else statements should begin on a new line [style_else_spacing]
              } else {
severity: normalreview: style_else_spacingLine 287: else statements should begin on a new line [style_else_spacing]
          } else {
severity: normalreview: style_else_spacingLine 301: else statements should begin on a new line [style_else_spacing]
          } else {
severity: normalreview: style_function_spacingLine 342: Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
            user_cookie_save(array ('gigya' => 'gigyaLogOut'));
severity: normalreview: style_else_spacingLine 359: else statements should begin on a new line [style_else_spacing]
      } else {
severity: normalreview: style_function_spacingLine 361: Functions should be called with no spaces between the function name and opening parentheses [style_function_spacing]
        user_cookie_save(array ('gigya' => 'gigyaLogOut'));
severity: normalreview: style_else_spacingLine 473: else statements should begin on a new line [style_else_spacing]
    } else {
severity: normalreview: style_else_spacingLine 496: else statements should begin on a new line [style_else_spacing]
        } else {
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_DEFAULT_TOKEN/GIGYA_DEFAULT_TOKEN.INSTALL
gigya_default_token.install

severity: normalreview: style_comma_spacingLine 18: missing space after comma [style_comma_spacing]
  db_delete('variable')->condition('name',db_like('gigya_default_token_extra_weights_%'), 'LIKE')->execute();
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_PANELS_PANES/PLUGINS/CONTENT_TYPES/COMMENTS.INC
comments.inc

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
severity: normalreview: style_else_spacingLine 127: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_else_spacingLine 151: else statements should begin on a new line [style_else_spacing]
    } else {
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_PANELS_PANES/PLUGINS/CONTENT_TYPES/FOLLOW_BAR.INC
follow_bar.inc

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
severity: normalreview: style_else_spacingLine 70: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_else_spacingLine 97: else statements should begin on a new line [style_else_spacing]
    } else {
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_PANELS_PANES/PLUGINS/CONTENT_TYPES/REACTIONS_BAR.INC
reactions_bar.inc

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
severity: normalreview: style_else_spacingLine 70: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_else_spacingLine 116: else statements should begin on a new line [style_else_spacing]
    } else {
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_PANELS_PANES/PLUGINS/CONTENT_TYPES/SHARE_BAR.INC
share_bar.inc

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
severity: normalreview: style_else_spacingLine 71: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_else_spacingLine 103: else statements should begin on a new line [style_else_spacing]
    } else {
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/INCLUDES/GIGYAACCOUNT.INC
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/INCLUDES/GIGYA.FIELD.INC
gigya.field.inc

severity: normalreview: i18n_0Line 315: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
          '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 433: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
          '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: i18n_0Line 506: The $text argument to l() should be enclosed within t() so that it is translatable. [i18n_0]
          '!JSON' => l('JSON', 'http://json.org', array(
severity: normalreview: style_array_spacingLine 529: Arrays should be formatted with a space separating each element and assignment operator [style_array_spacing]
      '#attributes' =>array('placeholder' => $follow_bar_placeholder),
severity: normalreview: style_else_spacingLine 688: else statements should begin on a new line [style_else_spacing]
      } else {
severity: normalreview: style_else_spacingLine 737: else statements should begin on a new line [style_else_spacing]
      } else {
severity: normalreview: style_else_spacingLine 796: else statements should begin on a new line [style_else_spacing]
      } else {
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/INCLUDES/GIGYA.RULES.INC
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/INCLUDES/GIGYA_COMMENTS.INC
gigya_comments.inc

severity: normalreview: style_else_spacingLine 124: else statements should begin on a new line [style_else_spacing]
    } else {
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/INCLUDES/PLACEHOLDERS.INC
placeholders.inc

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/JS/GIGYA.ADMIN.BEHAVIORS.JS
gigya.admin.behaviors.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/JS/GIGYA.BEHAVIORS.JS
gigya.behaviors.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/JS/GIGYA.JS
gigya.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/JS/GIGYA_COMMENTS.JS
gigya_comments.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/JS/GIGYA_FOLLOW_BAR.JS
gigya_follow_bar.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/JS/GIGYA_RATINGS.JS
gigya_ratings.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/JS/GIGYA_REACTIONS.JS
gigya_reactions.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/JS/GIGYA_SHAREBAR.JS
gigya_sharebar.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/JS/GIGYA_UPDATESTATUS.JS
gigya_updatestatus.js

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/THEME/GIGYA-ACTIVITY-FEED-BLOCK.TPL.PHP
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/THEME/GIGYA-LINK-ACCOUNTS.TPL.PHP
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/THEME/GIGYA-LOGIN-BLOCK.TPL.PHP
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/THEME/GIGYA-RAAS-BLOCK.TPL.PHP
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/THEME/GIGYA-REGISTER.TPL.PHP
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/THEME/GIGYA-USER-PICTURE.TPL.PHP
SHOWSITES/ALL/MODULES/CONTRIB/GIGYA/THEME/GIGYA-USER-PROFILE.TPL.PHP
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_DEFAULT_TOKEN/GIGYA_DEFAULT_TOKEN.MODULE
gigya_default_token.module

No Problems Found
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_DEFAULT_TOKEN/GIGYA_DEFAULT_TOKEN.INSTALL
gigya_default_token.install

severity: normalreview: style_comma_spacingLine 18: missing space after comma [style_comma_spacing]
  db_delete('variable')->condition('name',db_like('gigya_default_token_extra_weights_%'), 'LIKE')->execute();
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_PANELS_PANES/GIGYA_PANELS_PANES.MODULE
gigya_panels_panes.module

No Problems Found
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_PANELS_PANES/PLUGINS/CONTENT_TYPES/COMMENTS.INC
comments.inc

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
severity: normalreview: style_else_spacingLine 127: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_else_spacingLine 151: else statements should begin on a new line [style_else_spacing]
    } else {
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_PANELS_PANES/PLUGINS/CONTENT_TYPES/FOLLOW_BAR.INC
follow_bar.inc

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
severity: normalreview: style_else_spacingLine 70: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_else_spacingLine 97: else statements should begin on a new line [style_else_spacing]
    } else {
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_PANELS_PANES/PLUGINS/CONTENT_TYPES/REACTIONS_BAR.INC
reactions_bar.inc

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
severity: normalreview: style_else_spacingLine 70: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_else_spacingLine 116: else statements should begin on a new line [style_else_spacing]
    } else {
HIDESITES/ALL/MODULES/CONTRIB/GIGYA/GIGYA_PANELS_PANES/PLUGINS/CONTENT_TYPES/SHARE_BAR.INC
share_bar.inc

severity: normalreview: comment_docblock_fileFile: @file block missing (Drupal Docs) [comment_docblock_file]
severity: normalreview: style_else_spacingLine 71: else statements should begin on a new line [style_else_spacing]
  } else {
severity: normalreview: style_else_spacingLine 103: else statements should begin on a new line [style_else_spacing]
    } else {
CommentFileSizeAuthor
coding-standard.png129.63 KBRavindraSingh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RavindraSingh’s picture

Issue summary: View changes