What's the problem ?

When i use Linkit search plugin and i want to support menu_link.
The User class is used for search Menu_link and the user class search user by name, The menu_link class should search menu by link_title.

Correction

I have create a new class with menu_link name and i search menu_link via the new class.

Patches will be send soon.

CommentFileSizeAuthor
#7 menu_link.class_.zip921 bytesAnonymous (not verified)
#1 linkit_search_plugin_user_class_use_for_search_menu_link-719864-3.patch2.03 KBAnonymous (not verified)
#1 linkit_search_plugin_user_class_use_for_search_menu_link-719864-2.patch420 bytesAnonymous (not verified)
#1 linkit_search_plugin_user_class_use_for_search_menu_link-719864-1.patch431 bytesAnonymous (not verified)
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
linkit_search_plugin_user_class_use_for_search_menu_link-719864-1.patch431 bytes
linkit_search_plugin_user_class_use_for_search_menu_link-719864-2.patch420 bytes
linkit_search_plugin_user_class_use_for_search_menu_link-719864-3.patch2.03 KB

Add patches promised.
Please, check it quickly

Best regards.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Issue summary: View changes

The last submitted patch, 1: linkit_search_plugin_user_class_use_for_search_menu_link-719864-1.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 1: linkit_search_plugin_user_class_use_for_search_menu_link-719864-3.patch, failed testing.

The last submitted patch, 1: linkit_search_plugin_user_class_use_for_search_menu_link-719864-2.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
FileSize
menu_link.class_.zip921 bytes

I forgot to attach the new file created by the changes.

File path : linkit/plugins/linkit_search/menu_link.class.php

Sorry.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Title: Linkit Search plugin, User class use for search menu link » Search plugin for menu links
Version: 7.x-3.2 » 7.x-3.x-dev
Category: Bug report » Feature request
Priority: Major » Normal

Sound like a feature request and not a bug.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented
Related issues: +#2126749: Link to menu items
Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

It's a really a bug because the menu_link plugin is already in the linkit module but don't work.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented

No, there is no "menu_link plugin" in linkit core. That version are you using?

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Hi,

Effectively, the plugin is not present. However, when using modules like "xmlsitemap" or "entity_menu_links" an entity 'menu_link' is created so a plugin "menu_link" appear but does not work without this patch. So it is in this case really a bug.

but also menu_link plugin is much more practical because Linkit can do search on menu links (internal or external) and not only on node. And in this case this patch is also a new feature but need "entity_menu_links".

sorry for the late reply.

anon’s picture

anon
Primary language Swedish
Location Gothenburg
CreditAttribution: anon commented

When I test this, I get a lot of results that will put an empty url into the url field.

Also, the implemention of the menu_item entity in xmlsitemap is really messy I think.

delacosta456’s picture

delacosta456 CreditAttribution: delacosta456 commented

hi
any plan of update about this please ?

Thanks