The use of translated field descriptions in base field definitions and their inclusion in the entity database schema as column descriptions results in update.php changes if translations for those strings are available.
To reproduce, install in a non-en language, then import translations or manually translate something like "The node ID." to your language. Make sure to clear all caches after that.
Then visit update.php => oops.
It should run through, but that is no longer the case as soon as you have content, and it will also change in random ways depending on which language was used when the old values were generated. So if you then add another language, make that the default and visit newlanguage/update.php (it is a normal route now, so that actually works), it will be different *again*.
Additionally to that, descriptions are also used both as UI hints and DB schema descriptions, which is a dual role they cannot fulfill well. See. We need to either make them database descriptions or UI descriptions but not both.
Don't include descriptions in the entity database schema. This was a nice to have, not a mandatory feature. Most base field descriptions are so basic, they provide no additional information beyond the column name.
Calling t() as part of defining fields can lead to performance and other problems and we should avoid that, but solving that problem requires more changes and has been moved to.
User interface changes
|#136||interdiff.txt||600 bytes||Gábor Hojtsy|
|#136||2363099-no-description-in-schema-136.patch||14.55 KB||Gábor Hojtsy|
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,886 pass(es). View
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 85,882 pass(es). View
|#126||interdiff.txt||714 bytes||Gábor Hojtsy|