Fix coding standard errors in REST, HAL and Serialization modules

these bits

didn't merge HEAD

missed a use statement

1. +++ b/core/modules/hal/src/Normalizer/ContentEntityNormalizer.php
   @@ -187,6 +204,7 @@ public function denormalize($data, $class, $format = NULL, array $context = arra
   +      // @todo: Method 'denormalize' not found in class \Symfony\Component\Serializer\SerializerInterface
          $this->serializer->denormalize($field_data, $field_class, $format, $context);
   

   Er. This todo makes it sound like the line after it will fatal error. Assuming that doesn't happen, it means the comment is confusing.

2. +++ b/core/modules/hal/src/Normalizer/FieldNormalizer.php
   @@ -77,6 +81,7 @@ public function denormalize($data, $class, $format = NULL, array $context = arra
   +      // @todo Method 'denormalize' not found in class \Symfony\Component\Serializer\SerializerInterface
          $this->serializer->denormalize($field_item_data, $field_item_class, $format, $context);
   

   As above.

3. +++ b/core/modules/hal/src/Normalizer/FieldNormalizer.php
   @@ -101,6 +106,7 @@ protected function normalizeFieldItems($field, $format, $context) {
   +        // @todo Method 'normalize' not found in class \Symfony\Component\Serializer\SerializerInterface
            $normalized_field_items[] = $this->serializer->normalize($field_item, $format, $context);
   

   As above.

4. +++ b/core/modules/hal/src/Tests/NormalizerTestBase.php
   @@ -20,13 +20,13 @@
    /**
     * Test the HAL normalizer.
     */
   -abstract class NormalizerTestBase extends DrupalUnitTestBase {
   +abstract class NormalizerTestBase extends KernelTestBase {
   

   Why?

5. +++ b/core/modules/serialization/src/EntityResolver/UuidReferenceInterface.php
   @@ -20,7 +20,7 @@
   -   * @return string
   +   * @return string|null
       *   A UUID.
   

   Please clarify when null would be returned instead of a UUID string.

Other than those nits this seems quite reasonable.

To be honest I have no idea about the changes, other than that they were out of scope in the other issue (which I reviewed). I rolled the patch as penance for objecting over there.

Clemens can weigh in on them, then. :-)

Can someone properly title and scope this issue to say want is actually being changed here. thanks.

Better title, looking at the patch.

Needs work for the issue summary update and what we want to do here.

The patch doesn't apply anymore, I'm going redo it

I mainly focus on comments and variable names.. it requires more time than I though :(

re-uploading because I don't see the option for test :S

See https://www.drupal.org/core/scope for guidelines and examples for Drupal core issue scope. Coding standards are being handled by #2571965: [meta] Fix PHP coding standards in core, stage 1. Ideally coding standards should be fixed by enabling the rule in phpcs.xml.dist and fixing core to comply with the rule. That way we can test and prevent regressions.

@alexpott yes, I used code sniffer and I fixed a lot of things but there is still a lot of them...

@Saphyel the point is we're trying to make core comply with coding standards one by one see the sub issues of #2571965: [meta] Fix PHP coding standards in core, stage 1. Grab bag issues like this make that effort more complex. And if we do it that way we can prevent regressions and introducing new coding standards fails.

I think this issue should be closed because of scope. And effort put into #2571965: [meta] Fix PHP coding standards in core, stage 1 and it's children.

@clemens.tolboom oks sorry I misunderstand it