For D8 platforms, during verify the module is added to the packages but not the version.

CommentFileSizeAuthor
#2 2361729-2-add-module-version.patch1.39 KBjoestewart
#1 2361729-1-add-module-version.patch1.21 KBjoestewart
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

joestewart’s picture

joestewart CreditAttribution: joestewart commented
Status: Active » Needs review
FileSize
2361729-1-add-module-version.patch1.21 KB

patch checks for D8 and reads .info.yml file.

There are still quite a few modules that were packaged without a version.

joestewart’s picture

joestewart CreditAttribution: joestewart commented
FileSize
2361729-2-add-module-version.patch1.39 KB

Small addition to skip Drupal 8 modules that don't have a .info.yml.

helmo’s picture

helmo CreditAttribution: helmo commented

With a released version, e.g. http://ftp.drupal.org/files/projects/drupal-8.0.0-beta2.tar.gz it does work '8.0.0-beta2';

Maybe we should move/split this function to platform/drupal/packages_.inc

PS: With a D8 git clone we get 'VERSION' in the Release column on the packages tab. food for a follow-up issue ...

joestewart’s picture

joestewart CreditAttribution: joestewart commented

Thanks. Does that mean the patch worked for you?

Possibly should split some of these out. But wanted to see how much needed to change for 8 before going that route.

Yes, I debated adding this small check to cvs_deploy.inc

elseif ($version === 'VERSION') {
$version = _provision_cvs_deploy_version_from_tag(trim($match[1]));
}

joestewart’s picture

joestewart CreditAttribution: joestewart commented

I tried to find out in #drush whether drush is going to inject version info in .info.yml files for D8 like it does in drush_pm_inject_info_file_metadata for .info files

But I didn't get a response yet.

joestewart’s picture

joestewart CreditAttribution: joestewart commented

Related drush issue - drush_pm_inject_info_file_metadata() needs to be aware of yaml info files - https://github.com/drush-ops/drush/issues/943

  • helmo committed 98952e2 on 7.x-3.x authored by joestewart 
    Issue #2361729 by joestewart: Fixed D8 Platform verify doesn't add...
helmo’s picture

helmo CreditAttribution: helmo commented
Status: Needs review » Fixed

Merged.

Also https://github.com/drush-ops/drush/issues/943 is now merged but the recent drush works does seem to have some side effects #2373835: 3.x doesn't currently install

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.