Drupal 10, the latest version of the open-source digital experience platform with even more features, is here.#2267409: Cleanup makefile field on node/add/platform made changes to the makefile field in the platform form entry. These were incomplete. The insert and update were not changed to match the field changes.
patch will be attached.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | makefile_field_entries-2360995-8.patch | 1.81 KB | helmo |
| #7 | makefile_field_entries-2360995-7.patch | 439 bytes | helmo |
| #4 | 2360995-4-makefile-save.patch | 1.36 KB | joestewart |
| #1 | 2360995-1-makefile-save.patch | 1.08 KB | joestewart |
Comments
Comment #1
joestewart CreditAttribution: joestewart commentedupdated _insert and _update to match the form changes.
Comment #2
joestewart CreditAttribution: joestewart commentedComment #3
joestewart CreditAttribution: joestewart commentedAfter the verify is completed, the entry for the makefile gets deleted. looking now.
Comment #4
joestewart CreditAttribution: joestewart commentedrevised patch. Line 476 is ugly but the makefile entry didn't survive the verify after saving otherwise.
Comment #5
joestewart CreditAttribution: joestewart commentedoh, man. ignore #4. forgot I had commented out the node_save in hosting_platform_post_hosting_verify_task http://cgit.drupalcode.org/hosting/tree/platform/hosting_platform.drush....
Maybe someone else can fix. moving on for now.
Comment #6
joestewart CreditAttribution: joestewart commentedComment #7
helmo CreditAttribution: helmo commentedFound it ... sort of.
When the form API tries to store the platform node the value is in $node->frommakefile['makefile'].
But when you do a node_load, as provision does, you get $node-makefile ... The third hunk in this new path 'fixes' this.
However fixing #2347375: META: Convert pseudo fields to real fields. would also force us to do this properly.
Comment #8
helmo CreditAttribution: helmo commentedThe patch in #7had the wrong contents ... Here's the real patch.
Comment #10
helmo CreditAttribution: helmo commentedmerged
Comment #12
PolAdding new related issue. Patch will follow.