Problem/Motivation

Extending blocks is a fairly common thing to do in contrib. block_class for example, that allows to assign custom classes to blocks that can then be used for theming.

Right now, they have to store their settings separately, making it hard to deploy.

Proposed resolution

Integrate with the third party settings API

Remaining tasks

User interface changes

API changes

New methods on BlockInterface. (config entity block, not the block plugins)

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Berdir’s picture

Status: Active » Needs review
Issue tags: +Needs tests
FileSize
1.91 KB

First patch.

Status: Needs review » Needs work

The last submitted patch, 1: block-third-party-2358677-1.patch, failed testing.

swentel’s picture

Berdir’s picture

Status: Needs work » Needs review
Issue tags: +Contributed project blocker
FileSize
1.9 KB

Reroll.

Given the situation with the config schema in that issue, I don't know how to continue there, so giving this another push. Would be great for block_class: #2198023: Port Block Class to Drupal 8

Status: Needs review » Needs work

The last submitted patch, 4: block-third-party-2358677-4.patch, failed testing.

Berdir’s picture

Status: Needs work » Needs review
FileSize
2.4 KB
505 bytes

Fixed the test. Wondering if we really need test coverage for every third party settings implementations we add. On the other side, we often find bugs when actually providing an example implementation ;)

Berdir’s picture

Status: Needs review » Closed (duplicate)