Hello
Here is a patch that preserves the content_lock_token query string parameter between form posts in order to support content_lock module.

Without the patch, content_lock refuses to create a lock, so that can prevent a CSRF attack. As a result user is been asked to manually lock the node.

By the way, I am not sure if save_edit should preserve all Request variables and not only the “destination”

CommentFileSizeAuthor
#10 save_edit-support_for_content_lock-2358523-10.patch1.72 KBstefanos.petrakis@gmail.com
#4 save_edit-2358523_4.patch1.75 KBmelvinlouwerse
#2 save_edit-2358523.patch1.49 KBericpinxteren
#1 save_edit-2358523.patch1.5 KBericpinxteren
patch.txt1.9 KBcpsarros
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ericpinxteren’s picture

ericpinxteren CreditAttribution: ericpinxteren commented
FileSize
save_edit-2358523.patch1.5 KB

Fix path of patch.
Apply coding standard.

ericpinxteren’s picture

ericpinxteren CreditAttribution: ericpinxteren commented
FileSize
save_edit-2358523.patch1.49 KB

Fix url query.

ericpinxteren’s picture

ericpinxteren CreditAttribution: ericpinxteren commented
Status: Active » Needs review
melvinlouwerse’s picture

melvinlouwerse CreditAttribution: melvinlouwerse commented
FileSize
save_edit-2358523_4.patch1.75 KB

This patch is an extention of the previous patch.

It adds:
* check if the content lock module is enabled (if not we dont need to add the token)
* When no token is present create a new one so a new node will also be locked. (previously only updates on an existing node would get a lock)

mroest’s picture

mroest CreditAttribution: mroest commented

patch from @melvinlouwerse works for me!

stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented
Status: Needs review » Reviewed & tested by the community

Same here, this works for me too.
I will set this to "RTBC".

NitinSP’s picture

NitinSP CreditAttribution: NitinSP at Cognizant Technology Solutions commented
Assigned: Unassigned » NitinSP
NitinSP’s picture

NitinSP CreditAttribution: NitinSP at Cognizant Technology Solutions commented
Status: Reviewed & tested by the community » Fixed
NitinSP’s picture

NitinSP CreditAttribution: NitinSP at Cognizant Technology Solutions commented
Assigned: NitinSP » Unassigned
Status: Fixed » Reviewed & tested by the community
stefanos.petrakis@gmail.com’s picture

stefanos.petrakis@gmail.com
Primary language English
Location Biel, Switzerland
CreditAttribution: stefanos.petrakis@gmail.com as a volunteer commented
Status: Reviewed & tested by the community » Needs review
FileSize
save_edit-support_for_content_lock-2358523-10.patch1.72 KB

Rerolled against latest dev