Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.The makefile is could do with a bit of a cleanup to make it more readable.
Changes proposed (and included in upcoming patch);
- Removal of unnecessary quotation marks.
- Removal of Git repo path if hosted on D.o.
- Sectioning of types (Aegir core, Aegir golden, contrib, etc)
- Alphabetisation of sections.
- Addition of types for modules (sometime needed, depending on Drush).
- Addition of subdir for contrib (this will have to be dealt with in upgrade process).
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | clean_makefiles-2358413-2.patch | 6.67 KB | Deciphered |
Comments
Comment #1
Deciphered CreditAttribution: Deciphered commentedComment #2
Deciphered CreditAttribution: Deciphered commentedMinor update.
Comment #4
helmo CreditAttribution: helmo commentedWhat would we have to do for 'Addition of subdir for contrib' in terms of upgrade path? It's a new platform being build ... please reopen if I'm missing something.
Comment #5
ergonlogicWhile I'm fine with putting contrib dependencies in an isolated directory, I'd prefer that the Aegir modules, and probably "golden contrib", live in their own sub-directories.
Comment #6
ergonlogicDoes anyone know off-hand whether this would work in drupal-org.make?
Comment #7
ergonlogicIn 480f36a I added the defaults, and moved Aegir components into their own subdir. If the packaging scripts freak out, feel free to roll it back.
Comment #8
ergonlogicI ran the newly updated makefile through the drupalorg_drush 'validate-makefile', and it appears to pass using the defaults.