Follow-up to #2183983: Find hidden configuration schema issues

Problem/Motivation

http://privatepaste.com/8b541b5cc4 has the list of configuration that are missing config schema.

sample

    [views.view.about_us:display.default.display_options.access.dependencies] => Missing schema.
    [views.view.about_us:display.default.display_options.cache.dependencies] => Missing schema.
    [views.view.about_us:display.default.display_options.query.dependencies] => Missing schema.
    [views.view.about_us:display.default.display_options.exposed_form.dependencies] => Missing schema.
    [views.view.about_us:display.default.display_options.style.options.title] => Missing schema.
    [views.view.about_us:display.default.display_options.style.options.summary] => Missing schema.
    [views.view.about_us:display.default.display_options.style.options.description] => Missing schema.
    [views.view.about_us:display.default.display_options.filters.type.value] => Missing schema.

Proposed resolution

Remaining tasks

1. Add a test block with configuration that are missing schema.
2. Add missing schema and make patch green.
3.Review
4. Commit.

User interface changes

None.

API changes

Likely none.

Postponed until

#2224761: Add a generic way to add third party configuration on configuration entities and implement for field configuration

Files: 
CommentFileSizeAuthor
#19 config-checked.txt4.71 KBsidharrell
#7 2358265-diff-5-7.txt1.31 KBvijaycs85
#7 2358265-views-config-schema-7.patch2.65 KBvijaycs85
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2358265-views-config-schema-7.patch. Unable to apply patch. See the log in the details link for more information. View

Comments

vijaycs85’s picture

Gábor Hojtsy’s picture

Issue tags: -print +sprint

I think print was supposed to be sprint? :)

vijaycs85’s picture

Gábor Hojtsy’s picture

Issue tags: -

@vijaycs85: are you working on this? You put it on the sprint :)

vijaycs85’s picture

Status: Active » Needs review
Issue tags: -sprint
FileSize
1.34 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,758 pass(es). View

Sorry, Let's not get into sprint until get a working complete patch...

1.

    [views.view.about_us:display.default.display_options.style.options.title] => Missing schema.
    [views.view.about_us:display.default.display_options.style.options.summary] => Missing schema.
    [views.view.about_us:display.default.display_options.style.options.description] => Missing schema.

not sure which style we used (need plugin_id) to define the views.style.[plugin_id]

2.
[views.view.about_us:display.default.display_options.filters.type.value] => Missing schema.
Same as above. need the filter plugin_id to define views.filter_value.[plugin_id]

Updating patch just for dependencies.

dawehner’s picture

Ehem, I actually think that someone who cares about the config system and should not be named here, forgot to cleanup the exported views ... the dependencies are no longer stored for each plugin type,
but just on the most outer entity level.

1.

not sure which style we used (need plugin_id) to define the views.style.[plugin_id]

Oh well, ignore that, this is the the 'vertical_tabs' style, which is contrib, see the export:

      style:
        type: vertical_tabs
        options:
          row_class: ''
          default_row_class: true
          title: title
          summary: ''
          description: ''

2.

This is for the 'bundle' filter type.

vijaycs85’s picture

FileSize
2.65 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch 2358265-views-config-schema-7.patch. Unable to apply patch. See the log in the details link for more information. View
1.31 KB

Thanks @dawehner. Here is an update...

vijaycs85’s picture

Issue tags: +sprint
dawehner’s picture

Ehem, I actually think that someone who cares about the config system and should not be named here, forgot to cleanup the exported views ... the dependencies are no longer stored for each plugin type,

What about this?

Gábor Hojtsy’s picture

Issue tags: +Needs tests

What every committer would ask is where is the test for the changes as it happened in #2358263: Adding missing configuration schema for views blocks. I think it would be great to do these fixes with tests in mind. In talking to @alexpott before there is little chance fixes like this would get in without some test proof.

Gábor Hojtsy’s picture

Sent it for a retest because we now have a LOT more tests. What is the scope of this issue for fixes? Just the errors mentioned in the summary?

Status: Needs review » Needs work

The last submitted patch, 7: 2358265-views-config-schema-7.patch, failed testing.

Gábor Hojtsy’s picture

Issue tags: -sprint

Unfortunately not being actively worked on so removing from sprint.

sidharrell’s picture

I started working on a reroll, but many of the changes put into view.filter.schema.yml were already added on other tickets Gábor worked.
How was the original list generated? (I can't seem to access it through that link).
Can you point out examples of tests that are kinda close to the ones that need to be written here?

dawehner’s picture

@sidharrell
I had an existing site using the script in https://gist.github.com/dawehner/59fa62a36175e64d8383

Gábor Hojtsy’s picture

@dawehner: can you rerun that script on the (possibly now updated?) site?

sidharrell’s picture

FileSize
4.71 KB

I finally got that script running, thanks @dawehner.
I had a lot of trouble at first because I tried to put it in ~/.drush/ so it wouldn't be tied to a particular install, but the autoloader would not pick up SchemaCheckTrait from there. I finally just put it in a module instead. It didn't generate a list of missing config for me, though. I modded it slightly to produce a list of configs that it's checking (attached file), cause maybe (highly probable) I'm doing something wrong.

Gábor Hojtsy’s picture

@vijaycs85: Are the fixes in the proposed patch still relevant?

xjm’s picture

We discussed this in the CMI meeting today with @Gábor Hojtsy, @effulgentsia, @alexpott, etc. -- In general, for the tests, we should simply add a very basic stub test that uses the given plugin to expose the fail for the missing schema, and then file a normal followup issue to expand the test coverage for that plugin in Views.

Gábor Hojtsy’s picture

Issue tags: +sprint

Bring on D8MI sprint for consideration.

Gábor Hojtsy’s picture

Looking at the items listed in the issue summary:

- the dependencies ones looks like data bugs, there should not be dependencies stored on that level? why would views store dependencies on that level?
- the style ones look like a custom views style? which style has a title and a description stored?
- the filter value ones have a few maybe missing, but most of the patch does not apply anymore: views.filter_value.string, views.filter_value.in_operator and views.filter_value.bundle are not defined

Gábor Hojtsy’s picture

Title: Adding missing translation schema for views configuration » Some views schemas are (still) missing, maybe

Until we figure out what is going on here, I think "Some views schemas are (still) missing, maybe" is the best title for this one.

The last submitted patch, 7: 2358265-views-config-schema-7.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Closed (won't fix)

as explained in #23, we don't need to fix #23.1 and 2. Seems like #23.3 has been rolled back by #2357145: Views can not be saved with a numeric (grouped) filter. Not sure, anything left here to fix.

Gábor Hojtsy’s picture

Issue tags: -sprint

All righto, thanks!