Admin_menu checks for a processed admin_menu div in the DOM upon attachBehaviors. If it is not there, an AJAX call is made to load from cache. Once it is loaded, the processed class is added to prevent duplicate loading.

The problem is that attachBehaviors can be called again before the AJAX call returns. This results in duplicate AJAX calls and then eventually duplicate admin_menu divs in the DOM.

I'm attaching a patch that would keep track of whether the cache load call has been initiated and checks that prior to loading. I'm sure there are many different ways this could be addressed, this was just the first that came to mind.

CommentFileSizeAuthor
admin_menu.duplicate_ajax_load.0.patch979 byteseshta
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dysrama’s picture

+1 for this patch
This bug can give serious overhead on pages with a lot of content.

truls1502’s picture

Status: Needs review » Postponed (maintainer needs more info)
Issue tags: +postponed2w

I am sorry for no reply until now.

There are many issues regarding this module admin_menu which is a bit difficult for us to follow up since some of the issues might be already outdated, or is already fixed by the module or any other modules or itself core which means that the problem might no longer need to be fixed.

We can see that the issue has been created for a few years ago, I hope it is okay for you that I am postponing the issue, and give you around two weeks. If you still face the problem, could you tell us the step by step when until you get the error message or what is frustrated you, and a list of modules you are using related to admin_menu and a screenshot that might help us? So it makes us easier to reproduce your issue.

However, after two weeks with no feedback - we will close this issue. So in case, you noticed it after the issue is closed, do not hesitate to reopen it like and fill information which is mentioned above.

So before giving us a feedback, do you mind to test it again with our latest 7.x-3.x-dev?

Thank you for understanding! :)

truls1502’s picture

Status: Postponed (maintainer needs more info) » Closed (cannot reproduce)
Issue tags: -postponed2w

This issue has been automatically marked as closed because it has not had recent activity after the last post.

However, if you or someone is still facing the same issue as described to the issue, could you please to re-open the issue by changing the status of the issue, and add an explanation with more details which can help us to reproduce your situation.

Again, thank you for your contributions! :)