Hi,

I finally managed to get this module to work as expected.
Thanks again for the good work done.

However I face an issue: entering any of the albums from the fan page I've selected I see pictures multiple times, repeated again and again in sequence. If I click on one the colorbox opens and I see a lot of images available.

Not sure what's causing this problem, but since I gave you an URL for a test you may be able to verify by yourself.

Regards,

Francesco

Comments

b_sharpe’s picture

Assigned: Unassigned » b_sharpe
Status: Active » Fixed

Fixed in latest release (1.2)

b_sharpe’s picture

Status: Fixed » Closed (fixed)
FrancescoUK’s picture

Version: 7.x-1.1 » 7.x-1.2
Status: Closed (fixed) » Active

Unfortunately I need to reopen this issue since it's happening again.
Not sure what changed on Facebook side that this is recurring.

b_sharpe’s picture

It looks like the call to the api is being triggered more than once, I've assigned this to myself and will take a look when I get a chance. If you figure it out, submit a patch and I'll commit it.

FrancescoUK’s picture

Trying but not sure what is exactly going wrong. I'm not familiar with FB api and it might be something related to { limit: 10, after: photoAfter } in loadPhoto. Not sure though.

FrancescoUK’s picture

OK, probably I've got a bit more, it has something to do with the recursive call and paging story.
Something is probably not right with that part, maybe the cursor part.

I'll look better into this next days or over the week end.

b_sharpe’s picture

Status: Active » Fixed

Huge delay, I know, but this has been fixed in the latest release.

FrancescoUK’s picture

Hi,

many thanks for the fix, I attempted to make some sense of the root cause but then had no time to dig out more.

There is a strange side effect now, if you select albums after the first one the overall number of images is bigger and the starting image is offset from a 1st one that's coming from previous albums. Indeed if you click previous you'll navigate back to previous albums.

Regards,

Francesco

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

FrancescoUK’s picture

Please note that with version 2.0 I don't see anymore the side effect I mention in my previous post.
All work fine now. Thanks a lot to have worked on a newer version, it's a great improvement in general.