Problem/Motivation

On a client site we ran into an issue where we wanted to update the width for all users, but the width would supposedly not change (for the admin user) as this user had "customize ckeditor" permissions. This meant CKeditor would load the default width (100%) everywhere and ignore the values in the profile, while we never explicitly intended to override the editor width.

The reason for this is that when saving a user page with "customize ckeditor" permissions, the default values are used as the ones to override the profile values with, which is not what we want as the user never explicitly defined those.

Proposed resolution

Unless a value has been specifically defined by a user, we should stop overriding the profile values on a per user level, and use the value defined in the profile instead.

Remaining tasks

Review patch

User interface changes

Offer a "use site default" radio on all customizable options:

API changes

None

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stefan.r’s picture

Title: If user can customize CKEditor settings, » For users who can "customize ckeditor", settings can be overwitten with unwanted values
Status: Active » Needs review
Issue tags: -user experience
FileSize
6.65 KB
stefan.r’s picture

Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 1: 2355733-ckeditor-customize-default-1.patch, failed testing.

stefan.r’s picture

Issue summary: View changes
Status: Needs work » Needs review
FileSize
7.11 KB
55.76 KB
stefan.r’s picture

Status: Needs review » Reviewed & tested by the community

We have been running this for 2 years on several sites without any issues. Patch still applies, so marking RTBC

jcisio’s picture

Status: Reviewed & tested by the community » Needs work

Thank you stefan.r for your perseverance! Actually I've juts commit the first test case for the module. Could you add a test for this patch (and show the test fails without the fix)?