Problem/Motivation

The 1.x branch used to only get translations for all enabled languages.

As 2.x is a backport from D8 (which has no enabled/disabled state), it gets translations for all installed languages. If a language is disabled however, probably no interface translation is desired, so this is just extra download time and wasting disk space.

Proposed resolution

a) Only deal with enabled languages by default (such as in 1.x)
and/or
b) add a variable to either get translations for all enabled or all installed languages

Remaining tasks

User interface changes

If we add a variable, we will want to be able to set it in the admin UI.

API changes

Possibly: l10n_update_translatable_language_list() returns all installed languages as of yet.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

stefan.r’s picture

Status: Active » Needs review
FileSize
2.39 KB
623 bytes

One of these patches makes us only download enabled languages, the other merely adds a variable and other than that everything still works as in rc2 (but I wonder what the added benefit is to downloading disabled languages?)

Sutharsan’s picture

Category: Task » Bug report
FileSize
624 bytes

Although 7.x-2.x is a backport of 8.x, the is no requirement to translate disabled languages. It has not been requested in the issue queue. I will check 8.x for this behaviour as it has not been the intention to add it in 8.x too. Changing category to "bug".

You code will not work in PHP < 5.4.0. Therefore I have simply used the method from 7.x-1.x.

stefan.r’s picture

Thanks, patch looks good to me.

  • Sutharsan committed 026142b on 7.x-2.x
    Issue #2355557 by stefan.r, Sutharsan: Fixed 2.x downloads disabled...
Sutharsan’s picture

Status: Needs review » Fixed

Thanks, committed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.