Random failure in DisplayPathTest

Marked #2353457: Random test failure in Drupal\views_ui\Tests\DisplayPathTest duplicate.

Only nitpicks:

1. +++ b/core/modules/views/src/Plugin/views/display/PathPluginBase.php
   @@ -449,6 +450,15 @@ protected function validatePath($path) {
   +    $parsed_url = UrlHelper::parse($path);
   

   I think I know why this uses UrlHelper::parse() rather than parse_url(), but shouldn't we document that very briefly?

2. +++ b/core/modules/views/src/Plugin/views/display/PathPluginBase.php
   @@ -449,6 +450,15 @@ protected function validatePath($path) {
   +      $errors[] = $this->t('No path query allowed.');
   

   s/path query/query/
   ?

3. +++ b/core/modules/views_ui/src/Tests/DisplayPathTest.php
   @@ -92,8 +92,24 @@ public function testMenuOptions() {
   +    // Add an invalid path (empty just fragment).
   

   s/empty just fragment/only fragment/

4. +++ b/core/modules/views_ui/src/Tests/DisplayPathTest.php
   @@ -92,8 +92,24 @@ public function testMenuOptions() {
   +    // Add a path with a query.
   ...
   +    // Add a path with just a query.
   

   s/a path/an invalid path/

5. +++ b/core/modules/views_ui/src/Tests/DisplayPathTest.php
   @@ -92,8 +92,24 @@ public function testMenuOptions() {
   +    // Provide a valid path string.
   

   s/valid/random, valid/

Re-roll and fixed 2-5 from #5

I missed one string. Should be ok this time.

I saw this error myself. The fix is good, Wim's concerns are addressed and UrlHelper::parse supports internal urls vs parse_url doesn't, I doubt we need to add this to every place where we call it.

Committed 557bd08 and pushed to 8.0.x. Thanks!

[10-Oct-2014 14:24:59 UTC] Uncaught PHP Exception InvalidArgumentException: "The URI "base://AKI@&hO@" is invalid. You must use a valid URI scheme. Use base:// for a path, e.g., to a Drupal file that needs the base path. Do not use this for internal paths controlled by Drupal." at /var/lib/drupaltestbot/sites/default/files/checkout/core/lib/Drupal/Core/Url.php line 207

Just had an issue fail with the above problem - we've not quite fixed this one :(

+++ b/core/modules/views/src/Plugin/views/display/PathPluginBase.php
@@ -460,6 +461,10 @@ protected function validatePath($path) {
+      $errors[] = $this->t('Invalid path');

Why is it invalid? Could we hint what is wrong to the user here?

wow, maybe too much?
Can we explicitly say the reserved chars (2.2. Reserved Characters) in that spec?

Also an error message that is Invalid path, see Spec is very odd - no full stop. Personally I feel The path '@path' is invalid. is consistent with our other messages - for example the site front page and MenuLinkContentForm use a similar error message.

had one here too
#2341341-41: Change public 'name' property access on languages to getName() and add back setName()
base://>j*>&:}A

OK for me.

Good catch.

Committed and pushed to 8.0.x. Thanks!