The plan is this:

  • Create a class(GeshiFilter) to hold the constants and some helper functions.
  • Remove all debug/unused code inside classes/functions(i left some).
  • Remove all unused functions, some of then was moved to classes, but still exists a procedural version.
  • Fix all warnings from phpcs related to code style and documentation.
  • Fix some warning about code from phpstorm.
  • If a function is used only inside a class, move it to that class, if not move to a helper class with static functions.

The goals are remove all warnings about the code from phpcs/phpstorm and keep only hooks as procedural code.

This will do a lot of changes to code, but I think it is better do this now while working on D7->D8 upgrade.

Comments

  • yukare committed 0ff3218 on 8.x-1.x
    Issue #2353171 by yukare: Clean up the code and make it oo.
    
yukare’s picture

Status: Active » Fixed

Done with last commit. I think this is the last big change for D7->D8.

yukare’s picture

Version: 7.x-1.x-dev » 8.x-1.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.