Dynamic title for ajax rendered areas

I think so. I did a similar thing (node/%) but you have to modify the views_megarow_generic_render function a bit.

In views_megarow.module, around line 131, find the following line:

$commands[] = views_megarow_command_display(variable_get('views_megarow_title', t('Megarow content')), $output, $entity_id);

Replace variable_get('views_megarow_title', t('Megarow content')) with the desired title (use dpm($content to locate the title)).

You can see what I did in the attached patch file.

Hope that helps.

I'm aware of this problem. The major issue is where should I retrieve my dynamic title from? It brings the issue of storage, when we render the megarow content (and sets the title), we are out of range of the view object. The views object is the logic place where our title should be stored.
So by design it's not easily tweakable.
I don't want to have a callback defining a title base on the current path, i don't consider it as real fix.

Here's a patch.

Typos.

Thanks for the patches, instead of chaining the arguments in the textarea, let's do something smarter like a new field type.

That would mean a multi value field with 3 columns: label, path, title. Too complex and out of scope. As the first 2 are chained too, you'll need to solve those as well. I don't have time to deal with that separate issue but I'm ready to review if you can provide a patch.

In the meantime this is solving nice the issue even without the 3rd argument. It falls back to the route title and that is what people expect in 90% of cases. The 3rd argument can be used also with tokens to get a very customizable title.

OK, I created #2414863: Move the field options texarea into a multi-line field for your proposal. Now the problems are treated distinct.

Here is the patch from #7 rerolled for the newest dev.

Ignore the last patch. Accidentally changed a line unnecessarily.

+++ b/views_megarow.module
@@ -103,6 +103,15 @@ function views_megarow_generic_render($entity_id) {
+
+

Remove extra line.

Oops. My mistake. Here it is again.

@NWOM, if this worked for you, why not RTBC?

I'm not able to verify whether it is conform to drupal 7 coding standards, since I'm not a PHP programmer. I just wanted to help and re-roll the patch. Of course, I can set it to RTBC, just wasn't sure.

Thank you for your patch but please do not mark as RTBC an issue if it hasn't been tested by someone else and confirmed as OK.
As mentioned earlier in the issue, i would rather see #2414863: Move the field options texarea into a multi-line field pushed forwarded than complexing this field a bit more.

@Artusamak, the patch worked for him. So, he RTBC it after he tested :)

The other issue is not blocker for this. That one just makes the admin UI fancy. That one is not covering only the problems in this issue, so there's no reason to block this on that. That is a "nice to have", this is a real problem to megarow.

Hmm, my bad, i read a bit too fast. Thank you for the comment.

Your feedbacks are correct, i will examine the patch closer to commit it or not.

I found a small bug with the patch. My node titles are automatically generated based on the beginning of the body text via Automatic Entity Label. I coincidentally have a few nodes where the body text contained two periods ".." which is then consequently used in the Views Megarow Title and in the URL via the megarow_title querystring.

In this case it results in the following crash when clicking on the megarow link:

An AJAX HTTP error occurred.
HTTP Result Code: 403
Debugging information follows.
Path: /display_megarow/110544/node/110544?megarow_title=fsa..
StatusText: Forbidden
ResponseText: 403 Forbidden
nginx/1.8.0

I'm sure there are other potential characters that will also have the same effect.

This can be easily reproduced by adding ".." to any node title. Also, the megarow link works as expected when this patch has been removed.

@NWOM, I cannot reproduce the bug that you've described in #21. So, back to RTBC as per #20.

@claudiu.cristea: Did you attempt to reproduce the issue by adding two periods to a title? It is very easy to reproduce.

I honestly don't think it's that big of a deal, since it can be fixed by rules. However, it is still a regression in comparison to the module without the patch, since a title can currently have two periods without issues. The only reason why I marked it as needs work, is due to other characters that may fall into the same regression.

I created a megarow view based on nodes. I added 2 dots to title and saved. Everything went well.

Ah ok. Good to know. Thanks for the response.

Applied the patch in #15 to the latest dev and it worked great! It did exactly what I needed for a current project that I'm working on. I agree that only being able to set a title for all megarows isn't ideal. Having this functionality worked great!

The only minor issue I saw was on the textarea description at the end it says "Replacements ca be used for all parts." It should obviously read "Replacements can be used for all parts."

-      $links[] = $this->getLink($label, $url, array('class' => array('views-megarow-open')));
+      $links[] = $this->getLink($label, $url, $query, array('class' => 'views-megarow-open'));

If you do this, you will change the signature and may introduce regressions for classes potentially extending the views_handler_field_megarow_links handler. The argument should be added in last position.

+  if (!empty($_GET['megarow_title'])) {
+    $title = $_GET['megarow_title'];
+  }
+  else {
+    $route = menu_get_item($path);
+    $title = !empty($route['title']) ? $route['title'] : variable_get('views_megarow_title', 'Megarow content');
+  }
+

The title isn't sanitized when coming from the GET.