PDOException on newsletter node delete [#2351763]

Attempting to delete a node with no URL records will cause an error. This is because there is no check being done to verify that there are actually any URL records before trying to delete them.

PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1: DELETE FROM {simplenews_statistics_click} WHERE (urlid IN ()) ; Array ( ) in simplenews_statistics_delete_clicks() (line 495 of simplenews_statistics/simplenews_statistics.module).

Comment	File	Size	Author
#10	simplenews_statistics.module.patch	701 bytes	ilaz

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

7 October 2014 at 00:45

dieuwe committed a48f9eb on 7.x-1.x

Issue #2351763 by dieuwe: PDOException on newsletter node delete.

Comment #2

dieuwe

Auckland, NZ

CreditAttribution: dieuwe commented 7 October 2014 at 00:46

Status:

Active

» Fixed

Fix committed to development branch.

Comment #3

Hooligan CreditAttribution: Hooligan commented 10 October 2014 at 14:02

I just applied the update and still get an error when deleting a node.
PDOException: SQLSTATE[42S02]: Base table or view not found: 1146 Table 'votejuli_db.simplenews_statistics' doesn't exist: DELETE FROM {simplenews_statistics} WHERE (nid = :db_condition_placeholder_0) ; Array ( [:db_condition_placeholder_0] => 99 ) in simplenews_statistics_node_delete() (line 122 of /home/votejuli/public_html/sites/all/modules/simplenews_statistics/simplenews_statistics.module).

hmm, wonder why I'm missing a table.

Comment #4

Hooligan CreditAttribution: Hooligan commented 10 October 2014 at 14:23

I confirmed, the module install is not creating the table named simplenews_statistics

Comment #5

dieuwe

Auckland, NZ

CreditAttribution: dieuwe commented 10 October 2014 at 22:46

Are you doing an upgrade from an older dev version? Have you run update.php?

If so, simplenews_statistics_update_7001() should add the missing table.

Either way, your problem is not related to this issue, so please do open a new issue if the problem is not solved by my recommendations above.

Comment #6

24 October 2014 at 22:54

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Comment #7

redhatusr CreditAttribution: redhatusr commented 23 April 2015 at 09:50

I get the same error when I try to delete a newsletter

PDOException: SQLSTATE[42000]: Syntax error or access violation: 1064 You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '))' at line 1: DELETE FROM {simplenews_statistics_click} WHERE (urlid IN ()) ; Array ( ) in simplenews_statistics_delete_clicks() (line 495 of /var/www/html/sites/all/modules/simplenews_statistics/simplenews_statistics.module).

I upgrade from alpha1 to dev version with this way:
1. drush dis simplenews_statistics
2. rm simplenews_statistics -rf
3. drush dl simplenews_statistics --dev
4. drush en simplenews_statistics
5. drush updb

the upgrade from alpha1 to dev version give me WSOD with i just view the newsletter and apache error log says:

[Thu Apr 23 05:41:25 2015] [error] [client 192.168.1.44] PHP Fatal error: Call to undefined function simplenews_issue_newsletter_id() in /var/www/html/sites/all/modules/simplenews_statistics/simplenews_statistics.module on line 70

any ideas?

Comment #8

zanscath CreditAttribution: zanscath as a volunteer commented 3 August 2015 at 08:24

I got the same error when trying to delete a newsletter that hasn't been sent yet, not even to a test address. I think they didn't provide conditions for when no statistics are available for that node so perhaps you have to send it first or just click on the statistics tab for that newsletter at least once - I don't really know, but aster I did this, I could delete the newsletter.