CommentFileSizeAuthor
#3 quiz--psr0-test-cases.patch96.68 KBthehong
quiz--psr0-test-cases.patch23.71 KBthehong
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, quiz--psr0-test-cases.patch, failed testing.

thehong’s picture

thehong CreditAttribution: thehong commented
Status: Needs work » Needs review
FileSize
quiz--psr0-test-cases.patch96.68 KB

Status: Needs review » Needs work

The last submitted patch, 3: quiz--psr0-test-cases.patch, failed testing.

thehong’s picture

thehong CreditAttribution: thehong commented

I am not sure what's different, but the Drush test runner working fine for me

$ drush test-run --dirty --field-labels=0 'Quiz'
Starting test Drupal\long_answer\Tests\LongAnswerUnitTest.                        [ok]
Long answer 115 passes, 0 fails, 0 exceptions, and 30 debug messages         [ok]
…
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented

Try with scripts/run-tests.sh, that is the test runner that the drupal.org testbot runs.

I'm not entirely sure you can use PSR0 in Drupal 7 without adding to the files[] directive.

thehong’s picture

thehong CreditAttribution: thehong commented
Related issues: +#1693398: Allow PSR-0 test classes to be used in D7 (followups)
djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented
Status: Needs work » Postponed

Unfortunately we can't commit this until that makes it into D7 core.

thehong’s picture

thehong CreditAttribution: thehong commented
Assigned: Unassigned » thehong
Status: Postponed » Needs work

Hi Devin,

It's already in core for long time: https://github.com/drupal/drupal/blob/7.x/modules/simpletest/lib/Drupal/...

djdevin’s picture

djdevin
Location Philadelphia
CreditAttribution: djdevin commented

Someone should probably update those issues...

I don't see a pressing need for this, however if you can get it to work on d.o testbots I'll gladly commit.

thehong’s picture

thehong CreditAttribution: thehong commented
Status: Needs work » Closed (fixed)

I will try when I have other chance.

thehong’s picture

thehong CreditAttribution: thehong commented
Status: Closed (fixed) » Closed (won't fix)