Problem/Motivation

Follow-up issue to #1837118: UPDATE foo SET bar=(SELECT...) is not supported for PostgreSQL driver.

We need to implement sub select in update queries.

Proposed resolution

Compile arguments in expression if instance of SelectInterface (or SelectQueryInterface in D7).

Patch ported by chx, David_Rothstein, mradcliffe

Remaining tasks

- Attach patch from old issue.
- Run against tests.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 1837118-55.patch1 KBmradcliffe

Comments

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Status: Needs work » Needs review
StatusFileSize
new 1837118-55.patch1 KB
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue summary: View changes
mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented
Issue tags: -Needs backport to D7

Does not need back port this issue should have the patch for both #2350465: UPDATE foo SET bar=(SELECT...) is not supported in D7?.

fabianx’s picture

fabianx commented

So does that not still miss some new tests from the old issue?

Would be sad to loose some test coverage ...

mradcliffe’s picture

mradcliffe
he/him
Primary language English
commented

UpdateComplexTest is still in core.

Patch passes UpdateComplexTest on drupalci_testbot.

fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

RTBC then :)

bzrudi71’s picture

bzrudi71 commented

Perfect, local test run with patch from #1 applied makes UpdateComplexTest pass. +1 and RTBC from my side.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 2c88a12 and pushed to 8.0.x. Thanks!

  • alexpott committed 2c88a12 on 8.0.x 
    Issue #2350461 by mradcliffe, chx, David_Rothstein: Fixed issues with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.