Problem/Motivation

Visit /forum
Links in table go to taxonomy/term/{x} instead of forum/{x}
Major because forum is unusable

Proposed resolution

Fix

Remaining tasks

Everything

User interface changes

None

API changes

None

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Bug because forum index functionality is broken
Issue priority Major because it makes the main entry point to forums unusable.
CommentFileSizeAuthor
#11 forum-index-links-2350309-11.patch1.85 KBdroplet
#9 forum-index-links-2350309-9.patch1.61 KBdroplet
#7 forum-index-links-2350309-7.patch1.6 KBdroplet
#1 forum-index-links-2350309.pass_.patch1.47 KBlarowlan
#1 forum-index-links-2350309.fail_.patch626 byteslarowlan
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Status: Active » Needs review
FileSize
forum-index-links-2350309.fail_.patch626 bytes
forum-index-links-2350309.pass_.patch1.47 KB
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
Status: Needs review » Needs work
Related issues: +#2010132: Canonical taxonomy term link for forum vocabulary is broken

This hunk needs @todo for related

+++ b/core/modules/forum/forum.module
@@ -630,7 +630,7 @@ function template_preprocess_forum_list(&$variables) {
-    $variables['forums'][$id]->link = $forum->url();
+    $variables['forums'][$id]->link = Url::fromRoute('forum.page', ['taxonomy_term' => $forum->id()])->toString();

This shows broken url() method, maybe we need unittest in related issue

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

otoh we could move that to template layer

The last submitted patch, 1: forum-index-links-2350309.fail_.patch, failed testing.

The last submitted patch, 1: forum-index-links-2350309.pass_.patch, failed testing.

Status: Needs work » Needs review

droplet queued 1: forum-index-links-2350309.pass_.patch for re-testing.

droplet’s picture

droplet CreditAttribution: droplet commented
FileSize
forum-index-links-2350309-7.patch1.6 KB

Status: Needs review » Needs work

The last submitted patch, 7: forum-index-links-2350309-7.patch, failed testing.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review
FileSize
forum-index-links-2350309-9.patch1.61 KB

Status: Needs review » Needs work

The last submitted patch, 9: forum-index-links-2350309-9.patch, failed testing.

droplet’s picture

droplet CreditAttribution: droplet commented
Status: Needs work » Needs review
FileSize
forum-index-links-2350309-11.patch1.85 KB

local tested, no errors this time.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
CreditAttribution: larowlan commented
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community

Added beta issue template

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed bb21cc2 on 8.0.x 
    git commit -m 'Issue #2350309 by droplet, larowlan: Forum index links...

  • webchick committed 12bdc6c on 8.0.x 
    Revert "git commit -m 'Issue #2350309 by droplet, larowlan: Forum index...
  • webchick committed 7abdb65 on 8.0.x
    Issue #2350309 by droplet, larowlan: Forum index links head to taxonomy/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.