Currently to alter any of the previews a developer would have to do so in hook_page_alter ideally we would have a theme function, however, with time constraints I think it would be acceptable to use a simple alter so that users could adjust the elements that display here. For instance when the original image is insanely larger someone could link to the original instead of showing it in all its pixelated glory on the preview page.

I will be posting a patch shortly.

Thanks,

Jonathan

CommentFileSizeAuthor
#6 focal_point-2350139-6-add_alter_for_focal_point_preview.patch335 bytesawakash
#4 entityreference-no_save_autocomplete-1974202-4.patch1.12 KBawakash
#1 focal_point-2350139-1-add_alter_for_focal_point_preview.patch335 bytesgrndlvl
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

grndlvl’s picture

grndlvl CreditAttribution: grndlvl commented
Status: Active » Needs review
FileSize
focal_point-2350139-1-add_alter_for_focal_point_preview.patch335 bytes
grndlvl’s picture

grndlvl CreditAttribution: grndlvl commented
Assigned: grndlvl » Unassigned
bleen’s picture

bleen CreditAttribution: bleen commented
Status: Needs review » Needs work

I think this should really be a theme function ... if for some reason it *must* be an alter, than it needs an entry in focal_point.api.php

awakash’s picture

awakash CreditAttribution: awakash commented
FileSize
entityreference-no_save_autocomplete-1974202-4.patch1.12 KB

Ignore

awakash’s picture

awakash CreditAttribution: awakash commented
awakash’s picture

awakash CreditAttribution: awakash commented
FileSize
focal_point-2350139-6-add_alter_for_focal_point_preview.patch335 bytes

Since focal point is up to 7.x-1.0, I've updated this patch accordingly.

bleen’s picture

bleen CreditAttribution: bleen at NBCUniversal commented

@awakash - is there any reason why this *must* be an alter (as opposed to a theme function)?

grndlvl’s picture

grndlvl CreditAttribution: grndlvl at GollyGood Software for Advomatic commented

No it's not a must. it was simply the convenience at the time of implementation.

I agree it would be better to add a theme function for _focal_point_preview() for building the output instead of using the generic build array.