(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/views_ui/templates/views-ui-container.html.twig
core/modules/views_ui/templates/views-ui-display-tab-bucket.html.twig
core/modules/views_ui/templates/views-ui-display-tab-setting.html.twig
core/modules/views_ui/templates/views-ui-expose-filter-form.html.twig
core/modules/views_ui/templates/views-ui-rearrange-filter-form.html.twig
core/modules/views_ui/templates/views-ui-style-plugin-table.html.twig
core/modules/views_ui/templates/views-ui-view-info.html.twig
core/modules/views_ui/templates/views-ui-view-preview-section.html.twig

Files: 
CommentFileSizeAuthor
#4 copy_views_ui_templates-2349777-4.patch12.36 KBdanquah
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,464 pass(es), 9 fail(s), and 3 exception(s). View
#1 copy_views_ui_templates-2349777-1.patch6.89 KBmortendk
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,031 pass(es). View

Comments

mortendk’s picture

Status: Active » Needs review
Issue tags: +cssbanana
FileSize
6.89 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,031 pass(es). View

copyed templates & cleaned out classes

mortendk’s picture

Issue tags: +drupalhagen
danquah’s picture

Assigned: Unassigned » danquah
danquah’s picture

FileSize
12.36 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,464 pass(es), 9 fail(s), and 3 exception(s). View

The templates had moved a bit, so I have attached an update patch that needs a review.

danquah’s picture

Assigned: danquah » Unassigned
kallehauge’s picture

Assigned: Unassigned » kallehauge
kallehauge’s picture

Status: Needs review » Reviewed & tested by the community

Looks good. The templates are properly picked.

kallehauge’s picture

Assigned: kallehauge » Unassigned
alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/views_ui/templates/views-ui-display-tab-bucket.html.twig
@@ -17,14 +17,7 @@
-    'views-ui-display-tab-bucket',

This is used in views-admin.js - there will be more examples of this in the conversion.

I think this issue will be very hard to do successfully and I'm not convinced of the benefit.

The last submitted patch, 4: copy_views_ui_templates-2349777-4.patch, failed testing.

kallehauge’s picture

Assigned: Unassigned » kallehauge
kallehauge’s picture

Assigned: kallehauge » Unassigned

davidhernandez told me to gtfo of this issue due to possible changes. Unassigning myself.

lauriii’s picture

I dont really see any reason why we'd be moving views_ui classes to classy. No one anyways wants to change them..

cilefen’s picture

+1 for "Closed (won't fix)

cilefen’s picture

Status: Needs work » Postponed

Let's postpone this.

mortendk’s picture

the "nobody wanna fix this ever" is the reason that the frontend have been in such a ... bad... place.
We need to stop thinking that themers might not wanna fiddle with this & instead give em the tools to actually redesign, and rethink the visual of drupal.
- sorry to sound ranty - but its not an argument that "nobody wanna work with this" ;)

lauriii’s picture

Component: theme system » Classy theme
joelpittet’s picture

Version: 8.0.x-dev » 9.x-dev

Automated triage: bumping to 9.0.x because our API base themes (stable and classy) are locked in with the release of 8.0.x.

catch’s picture

Version: 9.x-dev » 8.3.x-dev
Priority: Normal » Minor

Moving back to 8.3.x and minor per #2349661: Copy config_translation templates to Classy.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.