(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/update/templates/update-last-check.html.twig
core/modules/update/templates/update-project-status.html.twig
core/modules/update/templates/update-report.html.twig
core/modules/update/templates/update-version.html.twig

Files: 
CommentFileSizeAuthor
#5 copy_update_templates-2349769-5.patch13.96 KBcilefen
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,564 pass(es), 2 fail(s), and 0 exception(s). View
#5 interdiff-2-5.txt15.21 KBcilefen
#2 copy_update_templates-2349769-2.patch12.29 KBcilefen
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,921 pass(es), 2 fail(s), and 0 exception(s). View

Comments

cilefen’s picture

Assigned: Unassigned » cilefen
cilefen’s picture

Assigned: cilefen » Unassigned
Status: Active » Needs review
FileSize
12.29 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,921 pass(es), 2 fail(s), and 0 exception(s). View

I think we want to move all of core/modules/update/css/update.admin.css to Seven.

cilefen’s picture

  1. +++ b/core/modules/update/templates/update-project-status.html.twig
    @@ -29,25 +29,16 @@
    -{%
    -  set status_classes = [
    -    project.status == constant('UPDATE_NOT_SECURE') ? 'security-error',
    -    project.status == constant('UPDATE_REVOKED') ? 'revoked',
    -    project.status == constant('UPDATE_NOT_SUPPORTED') ? 'not-supported',
    -    project.status == constant('UPDATE_NOT_CURRENT') ? 'not-current',
    -    project.status == constant('UPDATE_CURRENT') ? 'current',
    -  ]
    -%}
    

    These classes may be considered essential to the module's function.

  2. +++ b/core/modules/update/templates/update-project-status.html.twig
    @@ -55,46 +46,39 @@
    -{%
    -  set extra_classes = [
    -    project.status == constant('UPDATE_NOT_SECURE') ? 'project-not-secure',
    -    project.status == constant('UPDATE_REVOKED') ? 'project-revoked',
    -    project.status == constant('UPDATE_NOT_SUPPORTED') ? 'project-not-supported',
    -  ]
    -%}
    

    Also, these may be considered essential to the module's function. But since in this case this module is admin-only, it may be fine if they exist in Seven only.

Status: Needs review » Needs work

The last submitted patch, 2: copy_update_templates-2349769-2.patch, failed testing.

cilefen’s picture

Status: Needs work » Needs review
FileSize
15.21 KB
13.96 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,564 pass(es), 2 fail(s), and 0 exception(s). View

I moved the templates from class/templates/update to classy/templates and edited a test that referenced the class names.

davidhernandez’s picture

Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

cilefen’s picture

@davidhernandez - Thank for checking on the JS situation.

The update templates seem to work in Stark, but I should not be the last word. To anyone else testing, the update module paths are:

  • path: '/admin/reports/updates/settings'
  • path: '/admin/reports/updates'
  • path: '/admin/reports/updates/check'
  • path: '/admin/reports/updates/install'
  • path: '/admin/reports/updates/update'
  • path: '/admin/modules/install'
  • path: '/admin/modules/update'
  • path: '/admin/theme/install'
  • path: '/admin/theme/update'
  • path: '/admin/update/ready'

Status: Needs review » Needs work

The last submitted patch, 5: copy_update_templates-2349769-5.patch, failed testing.

cilefen’s picture

Status: Needs work » Postponed
lauriii’s picture

Component: theme system » Classy theme
joelpittet’s picture

Version: 8.0.x-dev » 9.x-dev

Automated triage: bumping to 9.0.x because our API base themes (stable and classy) are locked in with the release of 8.0.x.

catch’s picture

Version: 9.x-dev » 8.3.x-dev
Priority: Normal » Minor

Moving back to 8.3.x and minor per #2349661: Copy config_translation templates to Classy.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.