Copy simpletest templates to Classy

moved & removed classes

Works. The classy template file is picked up as it should.

So the module provides css for simpletest-fail and simpletest-pass and this has now moved to the classy template. I'm not sure that moving this template makes a whole lot of sense since I really don't believe this is the type of css themers really want to remove or override.

@alex i hear what your saying - But it would be inlogical to have templates thats not in the classy theme
A usecase for theming simpletest is when you build an admin theme, so it should be placed inside of classy

so yup themers want this :)

I'm not sure I buy the "illogical argument" - why is that so?

Also test running is something I do using stark all the time. And leaving the template in simpletest does not stop an admin theme from customising (but I'd bet at least 1 pence that no admin theme has ever wanted to remove the simpletest-pass and simpletest-fail classes.

simpletest have class'es - we wanna make drupal core free off all the classes & they should live inside of classy - not in the module.
The reason that everything should be in classy is that we want the themer to get a complete overview of the whole system.

does that make sense ?

I'm not sure I buy that for simpletest or views ui for that matter.

well the question is why do we wanna have classes down in core - when classes should be defined in the classy theme.

but its minor elements that isnt essential for classy's epic succes ;)

I'm too verbose below :) So here is a summary of my comment.

1. We didn't remove all of the classes.
2. We could remove them and move this information into data-attributes.
3. Eh... Let's just leave the class in core AND copy the twig template to classy. (Patch coming...)

1. This template, that would be moved to Classy in this patch, only wraps the *summary* of the simpletest results with a class (i.e. simpletest-pass/-fail/-debug). The table below that summary, which lists out each test, still has the same classes on the tr. The table tr class is added by simpletest module in core/modules/simpletest/src/Form/SimpletestResultsForm.php currently around line 178.

        $class = 'simpletest-' . $assertion->status;
        if ($assertion->message_group == 'Debug') {
          $class = 'simpletest-debug';
        }
        $rows[] = array('data' => $row, 'class' => array($class));

So we aren't really gaining much by moving one instance of adding the class to the theme layer and leaving the other in the module.

2. Trying to make everybody happy... we could still strip classes from core AND continue to pass on this relevant data information by putting it into a data-attribute on the element, changing the above to:

        $data_attribute = $assertion->status;
        if ($assertion->message_group == 'Debug') {
          $data_attribute = 'debug';
        }
        $rows[] = array('data' => $row, 'data-simpletest-result' => $data_attribute);

And this in the simpletest twig file:

<div data-simpletest-result="{{ fail + exception == 0 ? 'pass' : 'fail' }}">
  {{ label }} {{ items|join(', ') }}
</div>

3. However I think the most expedient route and acceptable (to me at least) would be to simply leave the class in core (as per @alexpott's point). AND for thoroughness and consistency of the the Classy project, duplicate the template to Classy.

I'll have a patch to that effect shortly.

Left class in core twig file per @alexpott AND copied twig file to Classy theme.

Thanks @davidhernandez. Trying again... leaving the class in core template and simply copying template to Classy.

I spoke to David on IRC. It seems like this patch does everything needed for this issue.

I still think we should grant an exception to the no classes in core aim for simpletest. Why do we want to make running tests in stark painful?

Lol... should have looked at the patch - we're not removing the classes anymore - so I wonder why we're putting this in classy. It does not seem relevant.

It looks like alexpott and I are raising similar concerns in a couple different issues. Let's postpone this on an updated issue summary + buy-in from core maintainers at #2349759: Copy system templates to Classy.

So i might could accept not moving This one template to classy, but thats it.
We cant have a template system that again is inconsistent all over

What were gonna do when all the templates are moved over, is putting them all in folders, so its easy to find, one of these folders would be "backend stuff" (or what we call em)
But i generally dissagrees everything must be moved to classy, lets not shake on the hand, just give us themers all em templates once n for all :)

Simpletest was moved to contrib in Drupal 9.0, https://www.drupal.org/node/3112907.

I am closing this as outdated.