(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/locale/templates/locale-translation-last-check.html.twig
core/modules/locale/templates/locale-translation-update-info.html.twig

Files: 
CommentFileSizeAuthor
#13 interdiff.txt1.9 KBkallehauge
#13 copy-locale-templates-2349719-12.patch4.7 KBkallehauge
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,561 pass(es), 2 fail(s), and 0 exception(s). View
#6 copy_locale_templates-2349719-6.patch2.4 KBfalkendk
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,652 pass(es). View
#1 copy_locale_templates-2349719-1.patch2.4 KBmortendk
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,030 pass(es). View

Comments

mortendk’s picture

Status: Active » Needs review
Issue tags: +cssbanana
FileSize
2.4 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,030 pass(es). View
davidhernandez’s picture

Status: Needs review » Needs work
+++ b/core/modules/locale/templates/locale-translation-update-info.html.twig
@@ -18,15 +18,15 @@
+<divtabindex="0" role="button">

Needs a space here between div and tabindex.

falkendk’s picture

falkendk’s picture

davidhernandez’s picture

@falkendk, your patch fixed the space. Thanks. But it does not copy the template files to the Classy theme. Also, make sure you set the status to "Needs review" so that others know to look at it. It will also tell testbot to test the patch. Thanks.

falkendk’s picture

Status: Needs work » Needs review
FileSize
2.4 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,652 pass(es). View

@davidhernandez thanks we try again.

mortendk’s picture

Issue tags: +drupalhagen
runand’s picture

Assigned: Unassigned » runand
runand’s picture

Assigned: runand » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good, the files are copied now.

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/locale/templates/locale-translation-update-info.html.twig
@@ -18,15 +18,15 @@
-  <span class="update-description-prefix visually-hidden">Show description</span>

This is used in locale.admin.js

kallehauge’s picture

Assigned: Unassigned » kallehauge
davidhernandez’s picture

Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

kallehauge’s picture

FileSize
4.7 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 83,561 pass(es), 2 fail(s), and 0 exception(s). View
1.9 KB

The "update-description-prefix" class now lives in classy and the module template file. They're also prefixed with "js-..."

Stupid me: forgot to reload the ticket to check for new comments when naming the file. Though I was post #12. My bad.

kallehauge’s picture

Assigned: kallehauge » Unassigned
Status: Needs work » Needs review
mortendk’s picture

+++ b/core/modules/locale/templates/locale-translation-update-info.html.twig
@@ -18,15 +18,15 @@
-<div class="inner" tabindex="0" role="button">

do we want to remove tabindex ?

mortendk’s picture

Status: Needs review » Needs work
kallehauge’s picture

Assigned: Unassigned » kallehauge

You're right Morten. Removing tabindex is out of the scope for this ticket

kallehauge’s picture

Assigned: kallehauge » Unassigned
Status: Needs work » Needs review

I'm quoting Morten now: "You can write that I'm an idiot". Morten is an idiot. tabindex was never removed #15 (:

Status: Needs review » Needs work

The last submitted patch, 13: copy-locale-templates-2349719-12.patch, failed testing.

davidhernandez’s picture

Status: Needs work » Postponed
lauriii’s picture

Component: theme system » Classy theme
joelpittet’s picture

Version: 8.0.x-dev » 9.x-dev

Automated triage: bumping to 9.0.x because our API base themes (stable and classy) are locked in with the release of 8.0.x.

catch’s picture

Version: 9.x-dev » 8.3.x-dev
Priority: Normal » Minor

Moving back to 8.3.x and minor per #2349661: Copy config_translation templates to Classy.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.