(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/link/templates/link-formatter-link-separate.html.twig

CommentFileSizeAuthor
#16 stark-patch-applied.png17.38 KBemma.maria
#16 stark-before-patch.png16.96 KBemma.maria
#13 copy_link_templates-2349715-13.patch949 bytessaki007ster
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,953 pass(es). View
#8 copy_link_templates_to-2349715-8.patch4.65 KBManuel Garcia
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch copy_link_templates_to-2349715-8.patch. Unable to apply patch. See the log in the details link for more information. View
#1 copy_link_templates_to-2349715-1.patch1.54 KBlauriii
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,430 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

lauriii’s picture

FileSize
1.54 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 81,430 pass(es). View
lauriii’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: copy_link_templates_to-2349715-1.patch, failed testing.

derheap’s picture

Status: Needs work » Postponed

The preprocess conversion is not done: #2329763: Move links classes from preprocess to templates is not in core yet.

lauriii’s picture

Assigned: Unassigned » lauriii
Status: Postponed » Needs work
lauriii’s picture

Assigned: lauriii » Unassigned

Ups didnt mean to assign

Manuel Garcia’s picture

Assigned: Unassigned » Manuel Garcia

Having a go at this...

Manuel Garcia’s picture

Assigned: Manuel Garcia » Unassigned
Status: Needs work » Needs review
FileSize
4.65 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch copy_link_templates_to-2349715-8.patch. Unable to apply patch. See the log in the details link for more information. View

Here is #1 plus the fixed tests in Drupal\link\Tests\LinkFieldTest.

Ran a recursive search on core for all three classes, they are just on the twig file so nothing else to do here I think.

Status: Needs review » Needs work

The last submitted patch, 8: copy_link_templates_to-2349715-8.patch, failed testing.

saki007ster’s picture

Assigned: Unassigned » saki007ster
saki007ster’s picture

FileSize
949 bytes
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 84,953 pass(es). View

Copied templates from link module to the classy theme and removed classes from the module template files.

saki007ster’s picture

Status: Needs work » Needs review
saki007ster’s picture

Assigned: saki007ster » Unassigned
emma.maria’s picture

Status: Needs review » Reviewed & tested by the community
FileSize
16.96 KB
17.38 KB
  • I searched core for the classes in link-formatter-link-separate.html.twig and found that none of them are used for any CSS or JS in core.
  • The template from the link module has been copied into Classy and it's contents are the same as the original.
  • The template in the link module has had all of it's classes removed.
  • Links display the same in the frontend
    Before:

    After:

Setting this issue to RTBC.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Template change is not blocked by beta. Committed 9d21438 and pushed to 8.0.x. Thanks!

  • alexpott committed 9d21438 on
    Issue #2349715 by emma.maria, saki007ster, lauriii, Manuel Garcia: Copy...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.