(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/language/templates/language-negotiation-configure-form.html.twig

Files: 
CommentFileSizeAuthor
#1 copy_language_templates-2349707-1.patch1.25 KBmortendk
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,647 pass(es). View

Comments

mortendk’s picture

Status: Active » Needs review
Issue tags: +cssbanana
FileSize
1.25 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,647 pass(es). View
mortendk’s picture

Issue tags: +drupalhagen
Xen’s picture

Assigned: Unassigned » Xen
Xen’s picture

Assigned: Xen » Unassigned
Status: Needs review » Reviewed & tested by the community

Is properly picked up in Bartik.

lauriii’s picture

Status: Reviewed & tested by the community » Needs work

Dunno whats wrong but the file is not created to classy

lauriii’s picture

Status: Needs work » Reviewed & tested by the community

Sorry for being headless lauri. Have to use git apply instead

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/core/modules/language/templates/language-negotiation-configure-form.html.twig
@@ -21,16 +21,9 @@
-      'table-language-group',

This is used in language.admin.js not sure we should be moving this to classy without a better plan.

Xen’s picture

Assigned: Unassigned » Xen

Missed that.

Then it should be prefixed by js- and applied differently... I'll look into it.

Xen’s picture

Well, seems that my D8-fu is not quite enough for the language-negotiation-configure-form...

In case anyone else want to give it a stab: The JS don't come into play until there's more than one negotiation type to be configured, which isn't the case by default. It's easy to do by running drush config-edit language.types and adding language_content to configurable. Secondly, one needs to be *not* locked, which isn't the case either per default. And I don't know when that'll be the case, so I ended up hacking it in for testing.

You'd think when you'd gotten all that in line, it would be a simple matter too add a class to the form render array and be done with it, but the template loops over language_types which isn't form elements, so adding a class attribute isn't as strait-forward as it could be.

Maybe some of the theming/template/form bigshots should take a look at this form. As it is, getting the js class in the proper place would be hacky, and I can't really spot the proper way to do it.

davidhernandez’s picture

Status: Needs work » Postponed
lauriii’s picture

Component: theme system » Classy theme
joelpittet’s picture

Version: 8.0.x-dev » 9.x-dev

Automated triage: bumping to 9.0.x because our API base themes (stable and classy) are locked in with the release of 8.0.x.

catch’s picture

Version: 9.x-dev » 8.3.x-dev
Priority: Normal » Minor

Moving back to 8.3.x and minor per #2349661: Copy config_translation templates to Classy.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.