(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/config_translation/templates/config_translation_manage_form_element.html.twig

CommentFileSizeAuthor
#3 stark-config-translation-after.png70.79 KBtstoeckler
#3 stark-config-translation-before.png83.57 KBtstoeckler
#2 copy_config_translation-2349661-2.patch1.06 KBmortendk
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,471 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

emma.maria’s picture

Status: Active » Needs review
Issue tags: +cssbanana

I have copied the template over and removed the classes from the template in the module folder.

There is a CSS file in the module that references the removed classes in the module template file so a follow up issue is needed to deal with this - tagged cssbanana as requested by @mortendk.

mortendk’s picture

FileSize
1.06 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,471 pass(es). View

copyed & cleaned the template

tstoeckler’s picture

Re #1: Yes, that's a good point! I don't see much value in keeping CSS around in a module that's targeted for a specific theme so why not move that into Classy as well directly?

Also uploading some screenshots of how this looks before and after in Stark. I guess the "regression" here is intentional as we want to make Stark as lean as possible, I just want to make sure that we are aware of it.

mortendk’s picture

yes i think we should when we have moved all templates over look hard at the css that each module outputs & move the css to where it actually belongs (in seven & bartik).

mortendk’s picture

Issue tags: +drupalhagen
Xen’s picture

Assigned: Unassigned » Xen
Xen’s picture

Assigned: Xen » Unassigned
Status: Needs review » Reviewed & tested by the community

Template picked up properly.

lauriii’s picture

Status: Reviewed & tested by the community » Needs work

Template is not generated to classy

lauriii’s picture

Status: Needs work » Reviewed & tested by the community

Dont be newbie like me, use git apply and everything is ok

davidhernandez’s picture

Status: Reviewed & tested by the community » Needs review

I'm universally setting all the phase 2 issues back to needs review, because we're missing some things. Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

Xen’s picture

Status: Needs review » Reviewed & tested by the community

The config_translation module does not have any js files.

And grepping the class names didn't turn anything up.

tstoeckler’s picture

Nope, no JS, this should be fine. The classes and CSS only serve to place the source and translation next to each other as shown in #3.

Thanks!

alexpott’s picture

Status: Reviewed & tested by the community » Needs work

So the question in the summary

If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven

has been discussed. But we have not chosen to either remove it or move it to (i guess) seven.

What is the plan?

davidhernandez’s picture

Status: Needs work » Postponed
lauriii’s picture

Component: theme system » Classy theme
joelpittet’s picture

Version: 8.0.x-dev » 9.x-dev

Automated triage: bumping to 9.0.x because our API base themes (stable and classy) are locked in with the release of 8.0.x.

Cottser’s picture

Version: 9.x-dev » 8.3.x-dev
Priority: Normal » Minor

If we copy the existing template to Stable (if it's not there already, I didn't check) and just change the template in core/modules, this would be safe to go into an 8.x minor, so moving to 8.3.x. Also, I'm thinking this might be minor because it's admin UI.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.