Scrolling toolbar when in vertical mode affects scrolling of page content [#2349411]

Comment	File	Size	Author
#11	2349411-prevent-scrolling-11.patch	785 bytes	kim.pepper

#8	prevent-scrolling-entire-page-2349411-8-D8.patch	780 bytes	rafenden

#4	prevent-scrolling-entire-page-2349411-4-D8.patch	718 bytes	rafenden

Comment #1

rafenden CreditAttribution: rafenden commented 3 October 2014 at 08:42

Issue summary:

View changes

Log in or register to post comments

Comment #2

rafenden CreditAttribution: rafenden commented 3 October 2014 at 08:56

Issue summary:

View changes

Log in or register to post comments

Comment #3

rafenden CreditAttribution: rafenden commented 3 October 2014 at 11:06

Issue summary:

View changes

Log in or register to post comments

Comment #6

rafenden CreditAttribution: rafenden commented 3 October 2014 at 11:28

File	Size
prevent-scrolling-entire-page-2349411-5-D8.patch	795 bytes

Added comment to patch.

Log in or register to post comments

Comment #7

blazey CreditAttribution: blazey commented 3 October 2014 at 11:49

Status:

Needs review

» Needs work

1 file was hidden/shown/deleted

File	Size
prevent-scrolling-entire-page-2349411-5-D8.patch	795 bytes

Scrolling works only once in Firefox on Ubuntu 14.04. After scrolling to the bottom you I can no longer scroll to the top (sidebar mode).

Log in or register to post comments

Comment #8

rafenden CreditAttribution: rafenden commented 3 October 2014 at 12:01

File	Size
prevent-scrolling-entire-page-2349411-8-D8.patch	780 bytes

1 file was hidden/shown/deleted

File	Size
prevent-scrolling-entire-page-2349411-4-D8.patch	718 bytes

Fixed compatibility with Firefox.

Log in or register to post comments

Comment #9

blazey CreditAttribution: blazey commented 3 October 2014 at 12:10

Status:

Needs work

» Needs review

Works fine in Firefox/ubuntu and Chrome/Windows. It would be nice to test in other browsers.

Log in or register to post comments

Comment #11

kim.pepper

English

🏄‍♂️🇦🇺Sydney, Australia

CreditAttribution: kim.pepper commented 7 March 2015 at 01:44

Status:	Needs work	» Needs review
Issue tags:	-Needs reroll

File	Size
2349411-prevent-scrolling-11.patch	785 bytes

Re-rolled on 8.0.x

Log in or register to post comments

Comment #12

joelpittet

English

Vancouver

CreditAttribution: joelpittet as a volunteer commented 2 December 2015 at 06:49

Status:

Needs review

» Postponed (maintainer needs more info)

This sounds a bit like scroll-jacking to me and may lead to other browser bugs down the road. Also not sure how touch devices will react to this.

Why is scrolling the page at the end of scrolling the div an undesired effect? It's what the browser does naturally and doesn't seem to cause a big problem.

Log in or register to post comments

Comment #13

2 December 2015 at 06:49

Version:

8.0.x-dev

» 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Log in or register to post comments

Comment #14

2 December 2015 at 06:49

Version:

8.1.x-dev

» 8.2.x-dev

Drupal 8.1.9 was released on September 7 and is the final bugfix release for the Drupal 8.1.x series. Drupal 8.1.x will not receive any further development aside from security fixes. Drupal 8.2.0-rc1 is now available and sites should prepare to upgrade to 8.2.0.

Bug reports should be targeted against the 8.2.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.