Problem/Motivation

The menu button (hamburger) is overlapping on Menu text when using RTL mode on mobile.

Proposed resolution

The button could be moved to the left side of the screen.

User interface changes

Menu text on RTL and mobile will be moved to the left side of the screen.

Remaining tasks

Write patch
Manual testing

API changes

n/o

CommentFileSizeAuthor
#11 hamburguer-menu-after.png26.58 KBrteijeiro
#11 hamburguer-menu-before.png27.19 KBrteijeiro
#10 interdiff.txt556 bytesstefika
#10 fix-menu-button-position-in-rtl-2349373-10.patch599 bytesstefika
#5 fix-menu-button-position-ltr.png68.59 KBskippednote
#2 fix-menu-button-position-in-rtl.patch609 bytesskippednote
#2 fix-menu-button-position-fixed.png57.99 KBskippednote
fix-menu-button-position.png67.17 KBskippednote

Comments

rvilar’s picture

rvilar
Primary language Catalan
Location Montcada i Reixac, Catalonia
commented
Assigned: Unassigned » rvilar

I'm working on that

skippednote’s picture

skippednote commented
Assigned: rvilar » Unassigned
Issue tags: +Amsterdam2014
StatusFileSize
new fix-menu-button-position-fixed.png57.99 KB
new fix-menu-button-position-in-rtl.patch609 bytes

Moved the menu button to left and it isn't overlapping anymore.

skippednote’s picture

skippednote commented
Status: Active » Needs review
tomefa’s picture

tomefa commented
Title: Fix menu button position in RTL » Hide menu label on primary menu
Status: Needs review » Needs work

Changed the issue title, what we have to do is to hide the primay menu label on a mobile screen size.
And keep the menu icon on the right.

skippednote’s picture

skippednote commented
StatusFileSize
new fix-menu-button-position-ltr.png68.59 KB

Are we sure we want to remove the Menu text? It's there in LTR and has been themed to be a part of the menu.

lewisnyman’s picture

lewisnyman
he/him
commented
Title: Hide menu label on primary menu » Menu label overlaps with the dropdown trigger on narrow screens on RTL
Category: Task » Bug report

Updated the title to reflect the problem

skippednote’s picture

skippednote commented
Status: Needs work » Needs review

moving to "Needs Review" now that the requirements are clear.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
tomefa’s picture

tomefa commented

Ok right, the menu label need to be display.
But because we are on a RTL language the menu label is better on the left and the hamburger on the right.
Like the admin menu.
What do you think ?

stefika’s picture

stefika commented
StatusFileSize
new fix-menu-button-position-in-rtl-2349373-10.patch599 bytes
new interdiff.txt556 bytes

Removing unnecessary comment.

rteijeiro’s picture

rteijeiro commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new hamburguer-menu-before.png27.19 KB
new hamburguer-menu-after.png26.58 KB

It looks good for me. Let's go for RTBC

BEFORE

AFTER

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and and is an unfrozen change, so it is allowed per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed 2ba5141 and pushed to 8.0.x. Thanks!

  • alexpott committed 2ba5141 on 8.0.x 
    Issue #2349373 by stefika, skippednote: Fixed Menu label overlaps with...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.