There was a release of Net_SmartIRC on September 4, and they updated the _nick variable to be protected, whereas before it was declared with var but documented as private access. Using bot.module with the new release gets you a friendly
Error: Cannot access protected property Net_SmartIRC::$_nick in /home/ksenzee/workspace/bot/sites/all/modules/bot/bot.module, line 312
and the bot crashes. If you install the old version of Net_SmartIRC (sudo pear install -f Net_SmartIRC-1.0.2) all is well.
A quick skim of the new release didn't turn up a getter method for the _nick property but I didn't look carefully.
Comment | File | Size | Author |
---|---|---|---|
#2 | 2349227-private_nick-2.patch | 1.6 KB | cafuego |
Comments
Comment #1
Morbus IffReported upstream here:
https://pear.php.net/bugs/bug.php?id=20419
Looks like it wasn't a really conscious decision - it's was marked as a "temporary" change for some other bug:
https://github.com/pear/Net_SmartIRC/commit/c90482fd04086957a7483498325f...
Comment #2
cafuego CreditAttribution: cafuego commentedThere doesn't appear to be a getter for _nick. Doh. Attached patch uses the new isMe() method instead.
Comment #3
cafuego CreditAttribution: cafuego commentedComment #4
Morbus Iff@cafuego: that patch won't work. Removing the bot name from bot_regexp() would break nearly every addressable function.
Anyways, if you upgrade to the latest Net_SmartIRC (later than 1.1.0), it should work again, with no change to bot.module.