The current test set we run with on ci.aegirproject.org does not include a D8 site.

This needs more work

CommentFileSizeAuthor
#9 test_d8-2348173-9.patch983 byteshelmo
D8_provision_test.patch1.92 KBhelmo
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

helmo’s picture

helmo CreditAttribution: helmo commented
Issue summary: View changes
helmo’s picture

helmo CreditAttribution: helmo commented
Issue summary: View changes

One patch I'm testing: https://git.drutch.nl/drupal-contrib/provision/commit/69b62f8e55228b06a3...

helmo’s picture

helmo CreditAttribution: helmo commented

The currennt point where it dies....

Drupal\Core\Extension\Extension Object                                                                                                [notice]
(
    [type:protected] => module
    [pathname:protected] => core/modules/views/views.info.yml
    [filename:protected] => views.module
    [splFileInfo:protected] =>
    [subpath] => modules/views
    [origin] => core
)
 [56.49 sec, 16.74 MB]
Drupal\Core\Extension\Extension Object                                                                                                [notice]
(
    [type:protected] => module
    [pathname:protected] => core/modules/views_ui/views_ui.info.yml
    [filename:protected] => views_ui.module
    [splFileInfo:protected] =>
    [subpath] => modules/views_ui
    [origin] => core
)
 [56.51 sec, 16.75 MB]
stdClass Object                                                                                                                       [notice]
(
    [weight] => 1000
)
 [56.52 sec, 16.76 MB]
Drush command terminated abnormally due to an unrecoverable error.                                                                 [error]
Error: Call to undefined method stdClass::getPathname() in /var/aegir/platforms/drupal8/core/modules/system/system.module, line 807
[56.7 sec, 23.66 MB]
PHP Fatal error:  Call to undefined method stdClass::getPathname() in /var/aegir/platforms/drupal8/core/modules/system/system.module on line 807

Fatal error: Call to undefined method stdClass::getPathname() in /var/aegir/platforms/drupal8/core/modules/system/system.module on line 807
The external command could not be executed due to an application error. [56.82 sec, 23.66 MB]
helmo’s picture

helmo CreditAttribution: helmo commented

We might be able to re-use something from https://github.com/drush-ops/drush/pull/738/files

helmo’s picture

helmo CreditAttribution: helmo commented

A new error I'm now getting:

Drush command terminated abnormally due to an unrecoverable error. Error: Method Drupal\Core\Url::__toString() must not throw an exception in /var/aegir/platforms/drupal-8.x-git/core/lib/Drupal/Component/Utility/String.php, line 0
The external command could not be executed due to an application error.
Undefined index: config_directories core.drush.inc:513
Invalid argument supplied for foreach() core.drush.inc:513
Drush was not able to start (bootstrap) the Drupal database. Hint: This may... (Expand)

Could be related to #2348879: Welcome Mail - url() deprecated.

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom commented

#2348879: Welcome Mail - url() deprecated. generates an error somehow

Drush command terminated abnormally due to an unrecoverable error. Error: Method Drupal\Core\Url::__toString() must not throw an exception in /data/aegir/src/provision/platform/drupal/install_8.inc, line 0

which is triggered by calling

  if ($client_email) {
    install_send_welcome_mail($url, $account, $install_locale, $client_email, $onetime);
  }

I noticed the Drupal 8 site was in error (it threw an exception) so maybe we should test with bypassing this client email first?

clemens.tolboom’s picture

clemens.tolboom
Primary language Dutch
Location Groningen, 🇳🇱/🇪🇺
CreditAttribution: clemens.tolboom commented

Hmmm 

mysql> select * from watchdog;

|  32 |   0 | php    | %type: !message in %function (line %line of %file). | a:5:{s:5:"%type";s:24:"UnexpectedValueException";s:8:"!message";s:126:"RecursiveDirectoryIterator::__construct(/data/aegir/platforms/drupal-8.x-git/sites/all): failed to open dir: Permission denied";s:9:"%function";s:41:"RecursiveDirectoryIterator->__construct()";s:5:"%file";s:90:"/data/aegir/platforms/drupal-8.x-git/core/lib/Drupal/Core/Extension/ExtensionDiscovery.php";s:5:"%line";i:322;} |        3 |      | http://d8.dev.voorbeeld-site.nl/           |                                                           | xxx | 1416297530 |

I have drwxrwx--- 3 aegir aegir 4096 Nov 11 16:25 all

helmo’s picture

helmo CreditAttribution: helmo commented

#7 is #2365175: D8 Platform sites/all created with insufficient permissions

#5 remains for me.

helmo’s picture

helmo CreditAttribution: helmo commented
Status: Active » Needs review
FileSize
test_d8-2348173-9.patch983 bytes

#5looks like collateral from #2348879: Welcome Mail - url() deprecated.

This patch seems to help... Anyone using these vars?

  • helmo committed d54d188 on 7.x-3.x 
    Issue #2348173 by helmo: Remove unused vars causing trouble
helmo’s picture

helmo CreditAttribution: helmo commented

The next error:

Returned from hook drush_provision_drupal_provision_verify_validate [36.64 sec, 19.26 MB]                                             [debug]
Calling hook drush_provision_git_provision_verify_validate [36.65 sec, 19.26 MB]                                                      [debug]
Returned from hook drush_provision_git_provision_verify_validate [36.65 sec, 19.27 MB]                                                [debug]
Calling hook drush_provision_drupal_pre_provision_verify [36.65 sec, 19.28 MB]                                                        [debug]
Found install profile <em class="placeholder">standard</em> [36.65 sec, 19.45 MB]                                                    [notice]
Found install profile <em class="placeholder">minimal</em> [36.65 sec, 19.46 MB]                                                     [notice]
Undefined index: default packages_8.inc:62 [36.65 sec, 19.46 MB]                                                                     [notice]
Creating default object from empty value packages_8.inc:63 [36.65 sec, 19.46 MB]                                                  [warning]
strpos(): Empty needle ExtensionDiscovery.php:201 [36.66 sec, 19.62 MB]                                                           [warning]
strpos(): Empty needle ExtensionDiscovery.php:201 [36.66 sec, 19.6 MB]                                                            [warning]
strpos(): Empty needle ExtensionDiscovery.php:201 [36.66 sec, 19.6 MB]                                                            [warning]
strpos(): Empty needle ExtensionDiscovery.php:201 [36.66 sec, 19.6 MB]                                                            [warning]
strpos(): Empty needle ExtensionDiscovery.php:201 [36.66 sec, 19.6 MB]                                                            [warning]
Undefined index: default system.module:860 [36.66 sec, 19.6 MB]                                                                      [notice]
Creating default object from empty value system.module:862 [36.66 sec, 19.6 MB]                                                   [warning]
Missing filter plugin: %filter. [36.71 sec, 23.76 MB]                                                                                     [1]
PHP Fatal error:  Call to undefined method stdClass::getPathname() in /var/aegir/platforms/drupal8/core/modules/system/system.module on line 877

Fatal error: Call to undefined method stdClass::getPathname() in /var/aegir/platforms/drupal8/core/modules/system/system.module on line 877
Drush command terminated abnormally due to an unrecoverable error.                                                                [error]
Error: Call to undefined method stdClass::getPathname() in /var/aegir/platforms/drupal8/core/modules/system/system.module, line
877 [36.73 sec, 23.48 MB]
The external command could not be executed due to an application error. [36.75 sec, 23.48 MB]                                     [error]
Reloading site drushrc.php from /var/aegir/platforms/drupal8/sites/drupal8-minimal.aegir.example.com/drushrc.php [36.75 sec, 16.85   [notice]
MB]
Returned from hook drush_provision_drupal_post_provision_import [36.76 sec, 16.85 MB]                                                 [debug]
Command dispatch complete [36.76 sec, 16.8 MB]                                                                                       [notice]
Returned from hook drush_hosting_task [36.78 sec, 23.44 MB]                                                                           [debug]
Changes made in drush_hosting_task have been rolled back. [36.79 sec, 23.44 MB]                                                    [rollback]
omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

I could see this "Call to undefined method stdClass::getPathname()" only on site Clone, or rather on the Import task, and the weird thing is that the clone in fact works fine - you just run Enable task and the site works.

I'm testing this with Drush 7 head and Drupal 8 head.

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

The workaround is to not run the backend verify sub-task in drush_provision_drupal_post_provision_import()

This commit may provide further hints: https://github.com/omega8cc/provision/commit/ba1c138c2363d3bc9107bad7b22...

joestewart’s picture

joestewart CreditAttribution: joestewart commented

Note also that #2362703: import_8 ineffective has a patch that allowed clones to maintain the install profile. The reason it is marked needs work is there is no fix or change to the global databases settings.

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

Ah, thanks for the pointer! I guess that is also the reason why the site name is never changed on Rename.

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

I have added a few fixes and I no longer see these errors.

  • helmo committed d54d188 on 7.x-4.x 
    Issue #2348173 by helmo: Remove unused vars causing trouble
gboudrias’s picture

gboudrias CreditAttribution: gboudrias at Praxis Labs Coop commented

What's the status on this?

The link in #16 is broken. Did we pull those fixes?

omega8cc’s picture

omega8cc CreditAttribution: omega8cc commented

Yes, all those fixes have been added in Provision. Sorry for not including issues and commits (listed previously in the Jenkins job) directly. It worked in our tests for D8 as long as we could test it with BOA, so up to Drupal 8.0.0-beta7: https://github.com/omega8cc/boa/issues/729

gboudrias’s picture

gboudrias CreditAttribution: gboudrias at Praxis Labs Coop commented
Status: Needs review » Fixed

Okay so the test part is fixed and was pushed in 3.0. Please reopen the status if I'm mistaken.

Drupal 8 itselft doesn't work by default (because Drush 6), but there are separate issues for this (#1194602: [meta] Support the hosting of Drupal 8 sites).

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.