When installing D8 the user is presented with an error if some required PHP extensions are missing.
This error message is displayed as HTML code and not as rendered HTML.
After some searching I found out that the problem happens because of system.install:118 where a concatenation with a string previously passed from t() happens. The concatenation introduces a <ul><li>.....</ul>
list that breaks the output. (see attached screenshots)
I tried to overcome the problem with many ways, but I couldn't do so while maintaining the list. So I attempted to change the output to something simpler, though still easy to read and understand by the end user.
The attached patch solves the problem.
I hope you like the approach
Comment | File | Size | Author |
---|---|---|---|
#8 | 2346509-double-escaping-error-message-in-php-modules-8.patch | 1.43 KB | bserem |
#1 | 2346509-missing_php_extensions_break_markup.patch | 1.42 KB | bserem |
drupal_install_php_extensions_markup_bug.jpg | 48.14 KB | bserem |
Comments
Comment #1
bserem CreditAttribution: bserem commentedComment #2
bserem CreditAttribution: bserem commentedComment #3
bserem CreditAttribution: bserem commentedComment #4
LinL CreditAttribution: LinL commentedThanks @bserem!
Looks like this is part of #2297711: Fix HTML escaping due to Twig autoescape
Comment #5
LinL CreditAttribution: LinL commentedComment #6
bserem CreditAttribution: bserem commentedThanks! I wasn't aware of it.
Comment #7
bserem CreditAttribution: bserem commentedComment #8
bserem CreditAttribution: bserem commentedAttached patch solves this the drupal way for php-extensions.
I am continuing on the related issues.
Comment #9
Zekvyrin CreditAttribution: Zekvyrin commentedThis issue is relevant to issue #2346287 and should be solved there.
https://www.drupal.org/node/2346287
Marking as duplicate.
Comment #10
jibran