in the calendar_ical.module, theme_calendar_ical_feed() calls date_ical_export without including date_api_ical.inc

CommentFileSizeAuthor
#11 ical927700.patch876 bytespelicani
#6 cal.patch797 byteswill_in_wi
#1 calendar_issue_234635.patch687 bytesjscheel
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jscheel’s picture

jscheel CreditAttribution: jscheel commented
FileSize
calendar_issue_234635.patch687 bytes

Patch attached.

jscheel’s picture

jscheel CreditAttribution: jscheel commented
Status: Active » Needs review
will_in_wi’s picture

will_in_wi CreditAttribution: will_in_wi commented
Status: Needs review » Reviewed & tested by the community

Works perfectly for me.

will_in_wi’s picture

will_in_wi CreditAttribution: will_in_wi commented

Correction. This patch fixes the symptoms, but the ical feed never gets any entries that are in the calendar. The ical export capability is really broken.

will_in_wi’s picture

will_in_wi CreditAttribution: will_in_wi commented

The hash in the function refers to the wrong members.

will_in_wi’s picture

will_in_wi CreditAttribution: will_in_wi commented
Status: Reviewed & tested by the community » Needs review
FileSize
cal.patch797 bytes

This patch fixes my issue with no information in the feed.

CarpeDiemEVive’s picture

CarpeDiemEVive CreditAttribution: CarpeDiemEVive commented

I can't make this patch work for me. I get an undefined function error for calendar_build_nodes(), which is in calendar.inc. I included calendar.inc and it still isn't showing any of the events.

KarenS’s picture

KarenS CreditAttribution: KarenS commented
Status: Needs review » Fixed

This is the right fix and should get things working correctly now. I may be that other problems that have since been fixed were affecting this, but the ical export works fine for me after committing this patch.

Thanks!

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.

pelicani’s picture

pelicani CreditAttribution: pelicani commented
Status: Closed (fixed) » Needs review

As were a few others, I have been having problems with exporting the ical feed.
I've downloaded the latest, but this patch was never put into the module package.
I would expect it to get rolled in, what am I missing?

I installed the second patch, and get the problem posted in comment #7.

Running Calendar 5.x-2.0-rc, Date 5.x-2.0-rc3, Views 5.x-1.6

Hoping to update this patch and get it committed.

peace,
michael

pelicani’s picture

pelicani CreditAttribution: pelicani commented
FileSize
ical927700.patch876 bytes

ah, there is one more include that needs to be called ...
include_once('./'. drupal_get_path('module', 'calendar') .'/calendar.inc');
this needs to be added before the call to calendar_build_nodes()

See attached patch.

peace,
michael

KarenS’s picture

KarenS CreditAttribution: KarenS commented
Status: Needs review » Fixed

Both of these changes are already committed. You won't see changes in the rc versions, they never change once they're released. The fixes go into the -dev version and show up in the next release. And there's a newer release than rc, there's a rc2 release you can use. I'm pretty sure the fix is in there, and if it's not, it's in the -dev version.

pelicani’s picture

pelicani CreditAttribution: pelicani commented
Status: Fixed » Closed (fixed)

downloaded latest dev, and is working fine.
thank you for your help.