Problem/Motivation

The installer removes English language during installation, if English as interface language during translation. Its not possible for install profile to ship with english as enabled language.

Proposed resolution

Add a new key to the installation profile info file.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#17 interdiff.txt852 bytesmauzeh
#14 keep-english-installer-2345969-14.patch3.1 KBmauzeh
#14 keep-english-installer-2345969-14-SHOULD-FAIL.patch2.7 KBmauzeh
#13 keep-english-installer-2345969-13.patch3.11 KBwebflo
#7 keep-english-installer-2345969-5-7.interdiff.txt404 byteswebflo
#7 keep-english-installer-2345969-7.patch3.02 KBwebflo
#5 keep-english-installer-2345969-5.patch2.63 KBwebflo
#1 keep-english-installer-2345969.patch18.88 KBwebflo

Comments

webflo’s picture

webflo commented
StatusFileSize
new keep-english-installer-2345969.patch18.88 KB

This patch depends on #2336743: When more than one language is added in the profile, the installer ignores those.

webflo’s picture

webflo commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: keep-english-installer-2345969.patch, failed testing.

Désiré’s picture

Désiré commented

The most parts of this patch is already committed, can you submit a new one with the actual changes?

webflo’s picture

webflo commented
Status: Needs work » Needs review
StatusFileSize
new keep-english-installer-2345969-5.patch2.63 KB

Rerolled and fixed the failing test.

Status: Needs review » Needs work

The last submitted patch, 5: keep-english-installer-2345969-5.patch, failed testing.

webflo’s picture

webflo commented
StatusFileSize
new keep-english-installer-2345969-7.patch3.02 KB
new keep-english-installer-2345969-5-7.interdiff.txt404 bytes

I forgot to include testing_multilingual.info.yml in the previous patch.

webflo’s picture

webflo commented
Status: Needs work » Needs review
webflo’s picture

webflo commented
Issue tags: +sprint

Status: Needs review » Needs work

The last submitted patch, 7: keep-english-installer-2345969-7.patch, failed testing.

webflo queued 7: keep-english-installer-2345969-7.patch for re-testing.

webflo’s picture

webflo commented
Status: Needs work » Needs review
webflo’s picture

webflo commented
StatusFileSize
new keep-english-installer-2345969-13.patch3.11 KB

Re-rolled after #2336743: When more than one language is added in the profile, the installer ignores those got in.

mauzeh’s picture

mauzeh commented
StatusFileSize
new keep-english-installer-2345969-14-SHOULD-FAIL.patch2.7 KB
new keep-english-installer-2345969-14.patch3.1 KB

* Added failing test.
* Small change to inline doc.
* Tested this in the GUI.
* Coding standard looks good.

This is something we should document, for instance at https://www.drupal.org/node/2210443 ("How to Write a Drupal 8 Installation Profile"). Will keep an eye on this issue and update the page when it is committed.

The last submitted patch, 14: keep-english-installer-2345969-14-SHOULD-FAIL.patch, failed testing.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Needs review » Reviewed & tested by the community

Rechecked with @mauzeh, looks good.

mauzeh’s picture

mauzeh commented
StatusFileSize
new interdiff.txt852 bytes

Whoops forgot the interdiff.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: keep-english-installer-2345969-14.patch, failed testing.

tstoeckler queued 14: keep-english-installer-2345969-14-SHOULD-FAIL.patch for re-testing.

tstoeckler queued 14: keep-english-installer-2345969-14.patch for re-testing.

The last submitted patch, 14: keep-english-installer-2345969-14-SHOULD-FAIL.patch, failed testing.

garphy’s picture

garphy
Primary language French
Location Montreal, Canada
commented
Status: Needs work » Reviewed & tested by the community

Tested it by adding keep_english in standard profile and it worked as it should.
I installed Drupal in French, and English was still there at the end.

I think it can be RTBC. Testbot is not happy because of the SHOULD-FAIL patch but the real patch is green.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 14: keep-english-installer-2345969-14.patch, failed testing.

Désiré queued 14: keep-english-installer-2345969-14.patch for re-testing.

webflo’s picture

webflo commented
Status: Needs work » Reviewed & tested by the community

Back to RTBC. The patch in #14 is green and war already RTBCed in #16

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 44ad6d7 and pushed to 8.0.x. Thanks!

  • alexpott committed 44ad6d7 on 8.0.x 
    Issue #2345969 by webflo, mauzeh: Fixed Keep English during installation...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue tags: -sprint +language-base

Superb, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.