Rename l() to _l() and url() to _url(), and document replacements

Blockers are fixed, not sure why this is still postponed.

#2343759: Provide an API function to replace url()/l() for external urls and others aren't fixed yet, there's no way to do the documentation part of this.

This is a simple rename that will apply on top of #2343759: Provide an API function to replace url()/l() for external urls.
Not marking needs review until then.

The docs replacements are really indicative of stale docs that really are talking about link or url generator.

Can we get a combined patch (here or on a patch testing issue) to see if this is green on top of #2343759: Provide an API function to replace url()/l() for external urls ?

1. +++ b/core/includes/common.inc
   @@ -640,7 +640,7 @@ function _format_date_callback(array $matches = NULL, $new_langcode = NULL) {
   +function _url($path = NULL, array $options = array()) {
   
   @@ -730,10 +730,10 @@ function drupal_http_header_attributes(array $attributes = array()) {
   +function _l($text, $path, array $options = array()) {
   

   Should we be adding @deprecated and 'documenting replacements' as per issue title?

2. +++ b/core/lib/Drupal/Core/Asset/CssOptimizer.php
   @@ -138,10 +138,10 @@ protected function loadNestedFile($matches) {
   +    // Alter all internal _url() paths. Leave external paths alone. We don't need
   
   +++ b/core/lib/Drupal/Core/Routing/UrlGeneratorInterface.php
   @@ -67,10 +67,10 @@
   +   *     generated. Only set if _url() is invoked by Drupal\Core\Entity\Entity::uri().
   
   +++ b/core/modules/filter/src/Tests/FilterDefaultConfigTest.php
   @@ -21,7 +21,7 @@ class FilterDefaultConfigTest extends DrupalUnitTestBase {
   +    // Drupal\filter\FilterPermissions::permissions() calls into _url() to output
   

   >80

stab at docs, patch is against #2343759: Provide an API function to replace url()/l() for external urls
interdiff is against #7

minor change

here's the patch at #10 plus the patch at #2343759: Provide an API function to replace url()/l() for external urls for a test-bot run.

Looks great to me. Just one nit:

+++ b/core/includes/common.inc
@@ -730,10 +745,27 @@ function drupal_http_header_attributes(array $attributes = array()) {
+ * $external_link = \Drupal::linkGenerator()->generate($external_link);

Perhaps the above can be fixed on commit or if this gets rerolled.

fixes #12

The do not test patch from #14, just in case someone is nervous about the bot.

Come on bot

Thanks testbot

Committed 002ae71 and pushed to 8.0.x. Thanks!

diff --git a/core/includes/common.inc b/core/includes/common.inc
index 7afd179..81c61b3 100644
--- a/core/includes/common.inc
+++ b/core/includes/common.inc
@@ -646,9 +646,9 @@ function _format_date_callback(array $matches = NULL, $new_langcode = NULL) {
  *   Use \Drupal\Core\Url::fromRoute() for internal paths served by Drupal
  *   controllers or \Drupal\Core\Url::fromUri() for external paths or
  *   non-controller or sub-domain URIs such as core/install.php. Note that
- *   \Drupal\Core\Url::fromUri() expects a valid URI including the scheme - In
- *   the case of URIs from the same sub-domain that are not handled by Drupal
- *   controllers, prepend base:://. For example:
+ *   \Drupal\Core\Url::fromUri() expects a valid URI including the scheme. URIs
+ *   from the same sub-domain that are not handled by Drupal controllers should
+ *   be prepended with base://. For example:
  * @code
  * $installer_url = \Drupal\Core\Url::fromUri('base://core/install.php')->toString();
  * $external_url = \Drupal\Core\Url::fromUri('http://example.com', ['query' => ['foo' => 'bar']])->toString();
@@ -753,9 +753,9 @@ function drupal_http_header_attributes(array $attributes = array()) {
  *   served by Drupal controllers use \Drupal\Core\Url::fromRoute(). For
  *   external paths or non-controller or sub-domain URIs such as
  *   core/install.php use \Drupal\Core\Url::fromUri(). Note that
- *   \Drupal\Core\Url::fromUri() expects a valid URI including the scheme - In
- *   the case of URIs from the same sub-domain that are not handled by Drupal
- *   controllers, prepend base:://. For example:
+ *   \Drupal\Core\Url::fromUri() expects a valid URI including the scheme. URIs
+ *   from the same sub-domain that are not handled by Drupal controllers should
+ *   be prepended with base://. For example:
  * @code
  * $installer_url = \Drupal\Core\Url::fromUri('base://core/install.php')->toString();
  * $installer_link = \Drupal::linkGenerator()->generate($installer_url);

Minor docs fixed on commit

DANCE DANCE DANCE!! :D

WOOT!

Oops. When I reviewed earlier, I missed that our _l() docs additions were also failing to pass the $text parameter in the example code.

I'm also unclear why we're telling people to call \Drupal::linkGenerator()->generate() when none of core does that, and lots of places in core call the shorter \Drupal::l() instead, so this changes the doc to match what core actually does.

So, can we get this docs fix in before the beta gets tagged? While this isn't actually critical or beta blocking, I'm leaving the issue attributes alone, to get this in front of a committer prior to beta.

Yep, that makes sense. Done in #2347831-7: Fix documentation for \Drupal::url(), \Drupal::l(), etc. (and fix the change record).

The change notice attached to this issue says that l() and url() deprecated. But they are actually gone. The change notice does not say they are removed or renamed. Please fix ASAP!