Hi,

I have found if I uninstall the job scheduler module, then it does not delete the variables created by job scheduler module.
These variables are unused if we are not using job_scheduler anymore.

Needs to create a patch for the same.

CommentFileSizeAuthor
#4 uninstall_variables.patch309 bytesvivekguptakota
#3 527096_22914_uninstall_variables.patch552 bytesRavindraSingh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RavindraSingh’s picture

RavindraSingh CreditAttribution: RavindraSingh commented
Title: Doesn't remove the variables on install. » Doesn't remove the variables on uninstall.
RavindraSingh’s picture

RavindraSingh CreditAttribution: RavindraSingh commented
Issue summary: View changes
RavindraSingh’s picture

RavindraSingh CreditAttribution: RavindraSingh commented
FileSize
527096_22914_uninstall_variables.patch552 bytes

Implemented patch for the issue

/*
* Implementation hook_uninstall().
*/
function job_scheduler_uninstall() {
db_query("DELETE FROM {variable} WHERE name LIKE 'job_scheduler%'");
}

vivekguptakota’s picture

vivekguptakota CreditAttribution: vivekguptakota commented
Assigned: RavindraSingh » Unassigned
FileSize
uninstall_variables.patch309 bytes

You can also add following code in .install file

/*
* Implements hook_uninstall().
*/
function job_scheduler_uninstall() {
variable_del('job_scheduler_rebuild_all');
}

RavindraSingh’s picture

RavindraSingh CreditAttribution: RavindraSingh commented

job scheduler generates variables dynamically. if you might have observed it with feeds module to adding importer id so variable_del('job_scheduler_rebuild_all'); is not sufficient. 

JobScheduler.inc:      $class = variable_get('job_scheduler_class_'. $name, 'JobScheduler');
job_scheduler.module:  if (variable_get('job_scheduler_rebuild_all', FALSE)) {
 job_scheduler.module:  if (variable_get('job_scheduler_rebuild_all', FALSE)) {
contrib/job_scheduler]$grep variable_set -r *
job_scheduler.module:    variable_set('job_scheduler_rebuild_all', FALSE);
job_scheduler.module:  variable_set('job_scheduler_rebuild_all', TRUE);
I have considered and tested to use 
db_query("DELETE FROM {variable} WHERE name LIKE 'job_scheduler%'");
RavindraSingh’s picture

RavindraSingh CreditAttribution: RavindraSingh commented
Status: Active » Reviewed & tested by the community

  • webflo committed 9baaba6 on 7.x-2.x 
    Issue #2342589 by RavindraSingh, vivekguptakota, webflo: Remove...
webflo’s picture

webflo CreditAttribution: webflo commented
Status: Reviewed & tested by the community » Fixed

Thanks! Merged both patches on commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.