Use routing to generate update.php url

+++ b/core/lib/Drupal/Core/Installer/Exception/AlreadyInstalledException.php
@@ -26,10 +26,10 @@ public function __construct(TranslationInterface $string_translation) {
 <li>View your <a href="!base-url">existing site</a>.</li>
 </ul>', array(
-      '!base-url' => $GLOBALS['base_url'],
+      '!update-url' => \Drupal::url('system.db_update'),

You might not want to replace !base-url because it's still used in the string.

I really like this issue.

+++ b/core/lib/Drupal/Core/Installer/Exception/AlreadyInstalledException.php
@@ -29,6 +29,7 @@ public function __construct(TranslationInterface $string_translation) {
+      '!update-url' => \Drupal::url('system.db_update'),
...
       '!update-url' => $GLOBALS['base_path'] . 'update.php',

Note: You have a duplicate array key so still the second one is used.

Removed the Url::fromRoute() call in AlreadyInstalledException as it's generating a RouteNotFoundException because it's called to early to have this route defined.

Thanks for tagging this for rc target triage! To have committers consider it for inclusion in RC, we should add a statement to the issue summary of why we need to make this change during RC, including what happens if we do not make the change and what any disruptions from it are. We can add a section <h3>Why this should be an RC target</h3> to the summary.

+++ b/core/lib/Drupal/Core/Installer/Exception/AlreadyInstalledException.php
@@ -30,6 +30,8 @@ public function __construct(TranslationInterface $string_translation) {
+      // We cannot use the route system.db_update here because we are too early
+      // in the execution stack so we would only get a RouteNotFoundException.
       ':update-url' => $GLOBALS['base_path'] . 'update.php',

I would actually name it different. Exceptions should not rely on any subsystem, as in case you do, you result in a potential even more potential broken system.

For #40.

I'd use some help there because, as a non-native speaker, I'm not sure to understand what you want :/

Replacing the occurrences only for $GLOBALS['base_url'] . '/update.php'with Url::fromRoute('system.db_update') and not where /update.php was replcaed with blank using str_replace().

Adding patch against 8.3.x version.

I am getting this type error when applying the patch

Checking patch core/lib/Drupal/Core/Installer/Exception/AlreadyInstalledException.php...
warning: core/lib/Drupal/Core/Installer/Exception/AlreadyInstalledException.php has type 100644, expected 100755
Hunk #1 succeeded at 3 (offset -5 lines).
error: while searching for:

', array(
':base-url' => $GLOBALS['base_url'],
':update-url' => $GLOBALS['base_path'] . 'update.php',
));
parent::__construct($message, $title);
}

error: patch failed: core/lib/Drupal/Core/Installer/Exception/AlreadyInstalledException.php:30
error: core/lib/Drupal/Core/Installer/Exception/AlreadyInstalledException.php: patch does not apply
Checking patch core/modules/system/src/Tests/Update/InvalidUpdateHookTest.php...
error: core/modules/system/src/Tests/Update/InvalidUpdateHookTest.php: No such file or directory
Checking patch core/modules/system/src/Tests/Update/UpdatesWith7xTest.php...
error: core/modules/system/src/Tests/Update/UpdatesWith7xTest.php: No such file or directory

Updated the comment to not mention the specific exception since that doesn't really matter.

Updated all tests to use Url::fromRoute('system.db_update'); that weren't already do so to make this consistent in core.

+++ b/core/modules/locale/tests/src/Functional/LocaleTranslatedSchemaDefinitionTest.php
@@ -71,7 +72,7 @@ public function testTranslatedUpdate() {
+    $update_url = Url::fromRoute('system.db_update');

+++ b/core/modules/system/tests/src/Functional/UpdateSystem/InvalidUpdateHookTest.php
@@ -49,7 +50,7 @@ protected function setUp(): void {
-    $this->updateUrl = $GLOBALS['base_url'] . '/update.php';
+    $this->updateUrl = Url::fromRoute('system.db_update');

+++ b/core/modules/system/tests/src/Functional/UpdateSystem/UpdatesWith7xTest.php
@@ -42,7 +43,7 @@ class UpdatesWith7xTest extends BrowserTestBase {
-    $this->updateUrl = $GLOBALS['base_url'] . '/update.php';
+    $this->updateUrl = Url::fromRoute('system.db_update');

Lines of instantiating of Url objects require an additional ->setAbsolute()->toString() methods call.

Addressed #65

Looks good

RTBC++

Confirmed that after applying the patch that the only remaining instance of "update.php" that is manually constructed is in AlreadyInstalledException, and a comment is added to that by this patch.

Committed and pushed 2a9221d556 to 10.1.x and 31d4a1a15c to 10.0.x and a161401833 to 9.5.x. Thanks!

Fixed the patch by moving the comment.

Backported to 9.5.x as all code changes are to tests.