strpos() expects parameter 1 to be string [#2341141]

Hi,

I get this error warning in the Content Type display screen when updating the display settings.
It doesn't seem to matter if any of them are displayed or hidden.

Values with the default option exist but do not use a token as a default value, so maybe something is being passing to the function when the input for the token is empty?

Warning: strpos() expects parameter 1 to be string, array given in field_default_token_field_update_instance() (line 23 of /www/befc/live/public/sites/all/modules/field_default_token/field_default_token.module).

Comments

Comment #1

Bensbury CreditAttribution: Bensbury commented 19 September 2014 at 01:55

Okay I have fixed this by doing the following.
I'm not a programmer so I can't give you one of those sexy patch files for review, but I will put the code in here:

I changed line 23 to the following because it is not always guaranteed the $column_value passed into this function is in fact a string.

  if (is_string( $column_value) && strpos($column_value, '[') !== FALSE) {

You can also brace up the line at 18 which is the almost the same with the following equivalent:

if (is_string( $value) && strpos($value, '[') !== FALSE)

Looks like it makes sense to me because by failing the conditional the $has_tokens variable will stay as false, which is correct.
If this doesn't mess up anything I hope it solves the problem and maybe makes the code more robust.

Cheers.