Problem/Motivation

OSM Mapnik is hard-coded to be accessed via http, but some sites may need maps to render under https. The service supports https/ssl requests via the exact same url, so there's no reason to hard-code the protocol.

Proposed resolution

Use headless urls ("//" instead of "http://") for map access.

Remaining tasks

Test and commit patch.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#3 leaflet-https_7x_11-2341015-3.patch1.13 KBJrgenGNielsen
#1 leaflet-https-2341015-1.patch1.41 KBfroboy
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
CreditAttribution: froboy commented
FileSize
leaflet-https-2341015-1.patch1.41 KB
gollyg’s picture

gollyg CreditAttribution: gollyg commented

Patch in #1 works as expected for me.

JrgenGNielsen’s picture

JrgenGNielsen CreditAttribution: JrgenGNielsen commented
FileSize
leaflet-https_7x_11-2341015-3.patch1.13 KB

Patch in #1 works nicely on 7.x-1.x
On 7.x-1.1, not so much... you may want this instead.

mikhailian’s picture

mikhailian CreditAttribution: mikhailian commented

The patch by @JrgenGNielsen is simple and straight to the point.

Here's some more info about protocol-relative urls. They are accepted everywhere where leafletjs works.

mikhailian’s picture

mikhailian CreditAttribution: mikhailian commented
Status: Active » Reviewed & tested by the community
froboy’s picture

froboy
he/him
Primary language English
Location Chicago, IL
CreditAttribution: froboy commented

Thanks all. This seems pretty straightforward and not have any opposition. Hopefully we can get a commit?

bazzmann’s picture

bazzmann CreditAttribution: bazzmann at Bazzmann Agency commented

Yes please, commit it. :)

  • RdeBoer committed a7fcf20 on 7.x-1.x authored by JrgenGNielsen 
    Issue #2341015 by froboy, JrgenGNielsen: Better support for https/ssl...
RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer as a volunteer commented
Assigned: Unassigned » RdeBoer

Committed.
Thanks froboy and JrgenGNielsen.
Available now in 7.x-1.x-dev and in 7.x-1.2 when released.
Rik

RdeBoer’s picture

RdeBoer
Location Melbourne
CreditAttribution: RdeBoer as a volunteer commented
Status: Reviewed & tested by the community » Fixed
bazzmann’s picture

bazzmann CreditAttribution: bazzmann at Bazzmann Agency commented

Thanks :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

netgeek123’s picture

netgeek123 CreditAttribution: netgeek123 commented

Google maps seems to be the only ones serving files through https.

astringer’s picture

astringer CreditAttribution: astringer commented

Removing my comment, it needs to go to leaflet mapbox.