Many coding standard errors [#2339391]

There are many coding standard violations which makes reviewing the code very hard.

http://pareview.sh/pareview/httpgitdrupalorgprojectdrupalchatgit refuses to run because there is a git tag that has the same name as the branch 7.x-1.x. Make sure to remove this tag to avoid confusion.

Coder Sniffer can be used to detect the coding standard errors.

Comment	File	Size	Author
#2	2339391-1.patch	61.4 KB	gurbakshish

Issue fork drupalchat-2339391

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

2339391-many-coding-standard compare
Check out this branch

About issue forks

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

rohit.rawat619 CreditAttribution: rohit.rawat619 at TO THE NEW commented 19 May 2023 at 10:44

Assigned:

Unassigned

» rohit.rawat619

Comment #2

gurbakshish CreditAttribution: gurbakshish at SV Infotech commented 19 May 2023 at 15:29

File	Size
2339391-1.patch	61.4 KB

Comment #3

apaderno

he/him

Italian

Brescia, 🇮🇹 🇪🇺

CreditAttribution: apaderno as a volunteer commented 19 May 2023 at 17:53

Status:

Active

» Needs work

+function drupalchat_app_settings()
+{
+    global $user;
+
+    if (isset($_SESSION['token']) && !empty($_SESSION['token'])) {
+        $token = $_SESSION['token'];
+    } else {
+        $json = _drupalchat_get_auth(array());
+        $token = $json['key'];
+    }
+
+    $drupalchat_host = DRUPALCHAT_EXTERNAL_A_HOST;
+    $host = explode("/", $drupalchat_host);
+    $host_name = $host[2];
+
+    $dashboardUrl = "https://". DRUPALCHAT_EXTERNAL_CDN_HOST ."/apps/dashboard/#/settings/app?sessid=". $token ."&hostName=". $host_name ."&hostPort=". DRUPALCHAT_EXTERNAL_A_PORT;
+    $form = array();
+    $form['drupalchat_app_dashboard'] = array(
+      '#type' => 'button',
+      '#attributes' => array('onClick' => 'window.open("'.$dashboardUrl.'","_blank")'),
+      '#value' => t('Click here to open App Dashboard'),
+    );
+
+    return $form;
+}

Code must be formatted following the Drupal coding standards, for which the indentation is two spaces and the opening curly parenthesis must be in the same line containing the function declaration, among other things.