Problem/Motivation

field_purge_batch() tries to purge fields that have no instances. field_read_instances() does not return instances attached to unknown entity types unless include_inactive is set in the $include_additional parameter. If you delete field instances in the disable hook of a module that provides an entity type, those instances will not be automatically purged. However, the fields will be purged automatically. Every time you uninstall the module, it will leave instances that have no corresponding fields in the field_config_instances table. These orphaned instances can only be deleted manually.

Proposed resolution

Pass include_inactive in the $include_additional parameter before attempting to purge fields.

Remaining tasks

  1. Review patch.
  2. Commit patch.
CommentFileSizeAuthor
#9 drupal-field_purge_batch-2337139-8.patch1.17 KBDarren Oh
#7 drupal-field_purge_batch-2337139-7.patch1.16 KBDarren Oh
#5 drupal-field_purge_batch-2337139-5.patch1.11 KBDarren Oh
#1 drupal-field_purge_batch-2337139.patch1.11 KBDarren Oh
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
Issue summary: View changes
FileSize
drupal-field_purge_batch-2337139.patch1.11 KB
Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
Assigned: Darren Oh » Unassigned
Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: drupal-field_purge_batch-2337139.patch, failed testing.

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
FileSize
drupal-field_purge_batch-2337139-5.patch1.11 KB

Fixed typo.

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
Status: Needs work » Needs review
Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
FileSize
drupal-field_purge_batch-2337139-7.patch1.16 KB

Changed wrong line.

Status: Needs review » Needs work

The last submitted patch, 7: drupal-field_purge_batch-2337139-7.patch, failed testing.

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
Status: Needs work » Needs review
FileSize
drupal-field_purge_batch-2337139-8.patch1.17 KB
Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh commented
Title: field_purge_batch() falsely assumes that instances attached to unknown entities do not exist » Fields with instances attached to unknown entities are deleted on cron run
Taran2L’s picture

Taran2L
Primary language Ukrainian
Location Lviv
CreditAttribution: Taran2L at Lemberg Solutions commented
Status: Needs review » Closed (duplicate)

Duplicate of #1340390: "Deleted" but "inactive" fields and instances cannot be removed during cron cleanup (e.g. for uninstalled entities).

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh at Cognizant Softvision for Estée Lauder Companies commented
Status: Closed (duplicate) » Needs review

This is not a duplicate. The other patch would still allow fields with inactive instances to be deleted before the instances have been deleted.

mcdruid’s picture

mcdruid
Location 🇬🇧🇪🇺
CreditAttribution: mcdruid at Acquia commented

Aren't the patches effectively exactly the same?

Darren Oh’s picture

Darren Oh
Primary language English
Location Lakeland, Florida
CreditAttribution: Darren Oh at Cognizant Softvision for Estée Lauder Companies commented

No, this patch fixes field deletion and the other patch fixes instance deletion.