Media Browser Settings for "WYSIWYG" aren't respected with CKEditor Module (e.g. browser tabs)

I applied this patch to media_wysiwyg version 7.x-2.0-alpha3+98-dev (in Panopoly 1.13), using CKEditor 7.x-1.16. It didn't seem to have any effect, so I resorted to just hiding the tabs I didn't want with CSS.

This worked for me, although it must require some cache clearing. When I first applied it it didn't fix it, and I followed dobie_gillis' advice and hid the extra tabs with CSS. But, when I came back to this issue a few days later to follow up, I now see that the tabs aren't present in the markup any more. So I'm thinking I failed to clear the cache after applying the patch and that's why the change didn't show up right away.

Clearing the cache still didn't fix the issue. I cleared both Drupal's cache and browser's cache.

I am using Ckeditor 7.x-1.16 and Media 7.x-2.0-alpha4+11-dev

It seems that the Ckeditor module is the issue.

I tested Ckeditor v4.4.6 using the Wysiwyg module, and that fixed the issue.

Patch no longer apply and needs to be rerolled and retested

git apply -v media_wysiwyg-ckeditor_module_browser_tabs-0.patch
Checking patch modules/media_wysiwyg/media_wysiwyg.module...
Hunk #1 succeeded at 228 (offset 40 lines).
Checking patch modules/media_wysiwyg/wysiwyg_plugins/media_ckeditor/library.js...
error: while searching for:
     */
    invoke: function (data, settings, instanceId) {
      if (data.format == 'html') {
        if (jQuery(data.node).is('.media-element')) {
          // Change the view mode for already-inserted media.
          var mediaFile = Drupal.media.filter.extract_file_info(jQuery(data.node));

error: patch failed: modules/media_wysiwyg/wysiwyg_plugins/media_ckeditor/library.js:13
error: modules/media_wysiwyg/wysiwyg_plugins/media_ckeditor/library.js: patch does not apply

Looks like this issue still exists with ckeditor module and media.

Patch re-rolled against current 7.x-2.x applies and works as expected. May need to empty caches when applying.

Patch #7 seems to work fine! I had restricted WYSIWYG to only allow image file type and it was still showing all types of files. Now it's only showing images.

+1 from me - the patch applies to 7.x-2.0-alpha4+37-dev (2015-Apr-24) and works as designed.

+1 for patch #7.

• Apply patch
• Reconfigurate settings at /admin/config/media/browser
• Clear caches

We are deprecating the ckeditor integration and moving it to a separate module.

Patch re-rolled against current 7.x-2.x for media_ckeditor module.
Applies and works as expected. May need to empty caches when applying.

Works with Media 7.x-2.x-dev

Also confirm this works with latest Media 7.x-2.x-dev, the tabs (Enabled browser plugins) works fine.

Though it would be nice to consider adding an allowed file extensions variable separate from the system wide "Default allowed file extensions" in "File settings" to limit uploaded files types since the current option "Allowed types in WYSIWYG" does not actually limit what can be uploaded, unless we are going to move the whole file type/extension thing #2533352: Rethink allowed extensions on field instance.

Patch works! Thnx!

The allowed file extensions for upload looks like a minor issue. I like the approach mentioned in https://www.drupal.org/node/2533352. The original issue seems fixed so I think it could be committed.

I updated the existing patch to fix the extension issue in https://www.drupal.org/node/2533326.

Requesting patch #13 to be commited, this is a major issue since the global tabs configuration is not being respected.

CKEditor integration has been moved to the Media CKEditor module

Patch 13 is actually for the media_ckeditor module now at http://www.drupal.org/project/media_ckeditor

however I did patch media with the first part of patch 13 to 'media' media_wysiwyg.js

http://cgit.drupalcode.org/media/commit/?id=7bdd246d6b3dece5ad4c19f571e0...

TODO: see patch 13 for media_ckeditor

Can someone please become maintainer of media_ckeditor and please commit this patch?

fixed in 7.x-2.x dev branch