Problem/Motivation

When reviewing #1912608: Update pagination markup for new CSS standards and improved accessibility with an old settings.php (with twig_debug set to TRUE) it was discovered that Twig trans block debug information is still hooked up to Settings rather than the Twig environment.

Proposed resolution

Fix it!

Remaining tasks

  • Patch
  • Tests likely need to be updated

User interface changes

n/a

API changes

n/a

Files: 
CommentFileSizeAuthor
#8 interdiff.txt1.11 KBCottser
#8 2332989-8.patch1.72 KBCottser
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,914 pass(es). View
#8 2332989-8-test-changes-only.patch1.11 KBCottser
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,820 pass(es), 11 fail(s), and 0 exception(s). View

Comments

Cottser’s picture

Status: Active » Needs review
FileSize
609 bytes
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Setup environment: Test cancelled by admin prior to completion. View

This is the line that needs to change at least.

Cottser’s picture

Okay it might not be that easy, env is protected…

Cottser’s picture

FileSize
674 bytes
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Setup environment: Test cancelled by admin prior to completion. View

Okay, this one I actually tested manually, should work :)

Cottser’s picture

FileSize
622 bytes
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,821 pass(es), 11 fail(s), and 0 exception(s). View

Can I just start this issue over? :)

The last submitted patch, 1: 2332989-1.patch, failed testing.

The last submitted patch, 3: 2332989-3.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2332989-4.patch, failed testing.

Cottser’s picture

Assigned: Cottser » Unassigned
Status: Needs work » Needs review
FileSize
1.11 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,820 pass(es), 11 fail(s), and 0 exception(s). View
1.72 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 75,914 pass(es). View
1.11 KB

Here are the test changes only, test changes + fix, and interdiff.

Edit: and yeah, test-changes-only == interdiff.

The last submitted patch, 8: 2332989-8-test-changes-only.patch, failed testing.

Fabianx’s picture

Status: Needs review » Reviewed & tested by the community

RTBC, looks great

Cottser’s picture

Issue summary: View changes

Thanks @Fabianx!

Fabianx’s picture

Issue tags: +Quickfix
alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 078f09a and pushed to 8.0.x. Thanks!

  • alexpott committed 078f09a on 8.0.x
    Issue #2332989 by Cottser: Fixed Twig trans tag debug is still hooked up...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.