Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Various fixes that we worked on over time in https://github.com/md-systems/globalredirect.
| Comment | File | Size | Author |
|---|---|---|---|
| #16 | globalredirect-chase-head-2332377-9.patch | 30.02 KB | LKS90 |
| #8 | globalredirect-chase-head-2332377-8.patch | 17.58 KB | Berdir |
| #4 | globalredirect-chase-head.patch | 17.57 KB | Berdir |
| #2 | globalredirect_form_fixes.patch | 868 bytes | Berdir |
| globalredirect-submit.patch | 528 bytes | Berdir | |
Comments
Comment #1
BerdirComment #2
Berdirnew patch to also update $form_state $handling.
Comment #4
BerdirRe-using this issue for a lot other fixes that we've been working on.
Comment #6
jhedstromI'd argue Berdir should get commit access to the 8.x branch to expedite getting these and other fixes in.
Comment #7
jhedstrom(I bumped to critical since the 8.x branch here doesn't work at all w/o these fixes)
Comment #8
BerdirUpdated the patch for recent core changes.
The isAnonymous() fatal was a core bug that was fixed in the meantime, so this should pass again.
Comment #10
chris_hall_hu_cheng CreditAttribution: chris_hall_hu_cheng commentedI punched the retest button on this, I have a pressing need for Global redirect, got an active Beta-7 site, I should have it tested and review by some point tomorrow.
Comment #11
chris_hall_hu_cheng CreditAttribution: chris_hall_hu_cheng commentedLooks good to me.
I tested this patch with the module against a fresh install of D8 dev and put it through the basic paces (deslash, redirect to url alias, clean url) and all worked. There we no errors or warnings generated in the logs during operation and installed.
I eye-balled the code changes, didn't spot anything obviously wrong.
I installed the patched version on a site recently migrated to Beta 7 (http://running-on-drupal8.co.uk/) and it works on there also.
Comment #12
BerdirThere are some new changes in the github repository that we need to sync back.
Comment #13
chris_hall_hu_cheng CreditAttribution: chris_hall_hu_cheng commentedI have a couple of other issues etc. that are taking up my time, if someone can prepare a new patch I can try it out and try it against latest lastest D8.
This module was really useful to me as I already had a D8 site more than a year old that had un-aliased urls indexed so good to get redirected to the new aliases.
Comment #14
chris_hall_hu_cheng CreditAttribution: chris_hall_hu_cheng commentedIf not I will will try to have a look at the weekend.
Comment #15
LKS90 CreditAttribution: LKS90 at MD Systems GmbH commentedBerdir asked me to update this patch according to changes in the github sandbox. So it should be fixed by this weekend (hopefully tomorrow, the sandbox version passes all tests and there shouldn't be many differences I hope).
Comment #16
LKS90 CreditAttribution: LKS90 at MD Systems GmbH commentedAlright, first try. This patch should make all tests pass. More specifically it adds some code for caching and does some other stuff which was fixed in the sandbox version + everything this patch did.
Comment #18
blueminds CreditAttribution: blueminds commentedCommitted, thanks!